Bug 76037

Summary: [EFL] Move macro checking to functions' definition in ewk_js.cpp.
Product: WebKit Reporter: Grzegorz Czajkowski <g.czajkowski>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, hyuki.kim, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: Linux   
Attachments:
Description Flags
proposed patch none

Grzegorz Czajkowski
Reported 2012-01-11 00:24:53 PST
Moves macro checking to functions definitions instead of duplicate them in source depending on macro value. It's known practice in WebKit and EFL port. Duplicating functions in the same file whose return value is different may confuse user, especially if macro isn't included in a patch.
Attachments
proposed patch (5.71 KB, patch)
2012-01-11 00:26 PST, Grzegorz Czajkowski 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Grzegorz Czajkowski
Comment 1 2012-01-11 00:26:26 PST
Created attachment 121990 [details] proposed patch
Raphael Kubo da Costa (:rakuco)
Comment 2 2012-01-11 05:23:57 PST
Looks good.
KwangHyuk
Comment 3 2012-01-11 05:30:31 PST
LGTM. :)
Gyuyoung Kim
Comment 4 2012-01-11 18:06:57 PST
Comment on attachment 121990 [details] proposed patch LGTM too. :-)
WebKit Review Bot
Comment 5 2012-01-12 03:48:57 PST
Comment on attachment 121990 [details] proposed patch Clearing flags on attachment: 121990 Committed r104806: <http://trac.webkit.org/changeset/104806>
WebKit Review Bot
Comment 6 2012-01-12 03:49:02 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.