Update and show ewk_view with updated webpage.

• Component: WebKit2
• Status: RESOLVED FIXED

[Eunmi Lee]

Update ewk_view with BackingStore image which is updated with shareableBitmap from WebProcess,
and show updated image's area when PageClientImpl::setViewNeedsDisplay() is called.

[Eunmi Lee]

Created attachment 121972 [details]
patch to update and show ewk_view.

[Ryuan Choi]

Comment on attachment 121972 [details]
patch to update and show ewk_view.

View in context: https://bugs.webkit.org/attachment.cgi?id=121972&action=review

> Source/WebKit2/UIProcess/API/efl/PageClientImpl.cpp:60
> -    evas_object_image_data_update_add(m_viewObject, rect.x(), rect.y(), rect.width(), rect.height());
> +    ewk_view_display(m_viewObject, rect);

Patch itself is good, but you should rebase this because m_viewObject is renamed.

> Source/WebKit2/UIProcess/API/efl/ewk_private.h:32
> +Eina_Bool ewk_view_display(Evas_Object* ewkView, const WebCore::IntRect& rect);
> +Eina_Bool ewk_view_image_data_set(Evas_Object* ewkView, void* imageData, const WebCore::IntSize& size);

Should we return Eina_Bool?

[Eunmi Lee]

Created attachment 122153 [details]
patch to update and show ewk_view.

Rebase and change Eina_Bool to bool.

[Eunmi Lee]

Thanks for your comments :)

(In reply to comment #2)
> (From update of attachment 121972 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=121972&action=review
> 
> > Source/WebKit2/UIProcess/API/efl/PageClientImpl.cpp:60
> > -    evas_object_image_data_update_add(m_viewObject, rect.x(), rect.y(), rect.width(), rect.height());
> > +    ewk_view_display(m_viewObject, rect);
> 
> Patch itself is good, but you should rebase this because m_viewObject is renamed.
=> Rebased.

> 
> > Source/WebKit2/UIProcess/API/efl/ewk_private.h:32
> > +Eina_Bool ewk_view_display(Evas_Object* ewkView, const WebCore::IntRect& rect);
> > +Eina_Bool ewk_view_image_data_set(Evas_Object* ewkView, void* imageData, const WebCore::IntSize& size);
> 
> Should we return Eina_Bool?
=> No, because those APIs are internal private API. so, I've changed Eina_Bool to bool type.

[Ryuan Choi]

> > > Source/WebKit2/UIProcess/API/efl/ewk_private.h:32
> > > +Eina_Bool ewk_view_display(Evas_Object* ewkView, const WebCore::IntRect& rect);
> > > +Eina_Bool ewk_view_image_data_set(Evas_Object* ewkView, void* imageData, const WebCore::IntSize& size);
> > 
> > Should we return Eina_Bool?
> => No, because those APIs are internal private API. so, I've changed Eina_Bool to bool type.

IMO, void looks enough.

[Eunmi Lee]

(In reply to comment #5)
> > > > Source/WebKit2/UIProcess/API/efl/ewk_private.h:32
> > > > +Eina_Bool ewk_view_display(Evas_Object* ewkView, const WebCore::IntRect& rect);
> > > > +Eina_Bool ewk_view_image_data_set(Evas_Object* ewkView, void* imageData, const WebCore::IntSize& size);
> > > 
> > > Should we return Eina_Bool?
> > => No, because those APIs are internal private API. so, I've changed Eina_Bool to bool type.
> 
> IMO, void looks enough.

=> I thought you mean to remove "Eina" type. I understand now and I agree with you that boolean return type is not necessary.
So, I will change return type from bool to void :)

[Eunmi Lee]

Created attachment 122182 [details]
patch to update and show ewk_view.

Change return type from bool to void.

[Ryuan Choi]

(In reply to comment #7)
> Created an attachment (id=122182) [details]
> patch to update and show ewk_view.
> 
> Change return type from bool to void.

Looks good to me.

[WebKit Review Bot]

Comment on attachment 122182 [details]
patch to update and show ewk_view.

Clearing flags on attachment: 122182

Committed r104804: <http://trac.webkit.org/changeset/104804>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.