Bug 75980

Summary: Change -[WebHistoryItem copyWithZone:] to not use NSCopyObject()
Product: WebKit Reporter: mitz
Component: HistoryAssignee: mitz
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch mrowe: review+

mitz
Reported 2012-01-10 11:47:20 PST
Change -[WebHistoryItem copyWithZone:] to not use NSCopyObject()
Attachments
Patch (1.33 KB, patch)
2012-01-10 11:48 PST, mitz 		no flags
DetailsFormatted DiffDiff
Patch (1.48 KB, patch)
2012-01-10 11:56 PST, mitz 		no flags
DetailsFormatted DiffDiff
Patch (1.48 KB, patch)
2012-01-10 11:59 PST, mitz 		mrowe: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2012-01-10 11:48:31 PST
Created attachment 121881 [details] Patch
Darin Adler
Comment 2 2012-01-10 11:51:43 PST
Comment on attachment 121881 [details] Patch Maybe you should have used initWithWebCoreHistoryItem instead?
mitz
Comment 3 2012-01-10 11:56:24 PST
Created attachment 121885 [details] Patch
Mark Rowe (bdash)
Comment 4 2012-01-10 11:58:44 PST
Comment on attachment 121885 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=121885&action=review > Source/WebKit/mac/History/WebHistoryItem.mm:145 > + historyItemWrappers().set(core(_private), copy); I think you want core(copy->_private) here.
mitz
Comment 5 2012-01-10 11:59:00 PST
Created attachment 121886 [details] Patch
mitz
Comment 6 2012-01-10 12:03:16 PST
Committed <http://trac.webkit.org/r104613>.
Note You need to log in before you can comment on or make changes to this bug.