Bug 75975

Summary: Use SameValue to compare property descriptor values
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fix sam: review+

Gavin Barraclough
Reported 2012-01-10 11:13:24 PST
Rather than strictEqual.
Attachments
Fix (11.88 KB, patch)
2012-01-10 11:16 PST, Gavin Barraclough 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2012-01-10 11:16:51 PST
Created attachment 121874 [details] Fix
WebKit Review Bot
Comment 2 2012-01-10 11:18:26 PST
Attachment 121874 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1 Source/JavaScriptCore/runtime/PropertyDescriptor.cpp:185: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Total errors found: 1 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Gavin Barraclough
Comment 3 2012-01-10 11:23:22 PST
Fixed in r104602
Note You need to log in before you can comment on or make changes to this bug.