Bug 75975 - Use SameValue to compare property descriptor values
Summary: Use SameValue to compare property descriptor values
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-10 11:13 PST by Gavin Barraclough
Modified: 2012-01-10 11:23 PST (History)
1 user (show)

See Also:

Attachments
Fix (11.88 KB, patch)
2012-01-10 11:16 PST, Gavin Barraclough 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2012-01-10 11:13:24 PST 
Rather than strictEqual.
Comment 1 Gavin Barraclough 2012-01-10 11:16:51 PST 
Created attachment 121874 [details]
Fix
Comment 2 WebKit Review Bot 2012-01-10 11:18:26 PST 
Attachment 121874 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1

Source/JavaScriptCore/runtime/PropertyDescriptor.cpp:185:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Gavin Barraclough 2012-01-10 11:23:22 PST 
Fixed in r104602