Bug 75968

Summary: Web Inspector: make source urls relative to source map url.
Product: WebKit Reporter: Pavel Podivilov <podivilov>
Component: Web Inspector (Deprecated)Assignee: Pavel Podivilov <podivilov>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch yurys: review+

Pavel Podivilov
Reported 2012-01-10 09:05:00 PST
Web Inspector: make source urls relative to source map url.
Attachments
Patch (6.19 KB, patch)
2012-01-10 09:06 PST, Pavel Podivilov 		no flags
DetailsFormatted DiffDiff
Patch (6.31 KB, patch)
2012-01-11 07:07 PST, Pavel Podivilov 		yurys: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pavel Podivilov
Comment 1 2012-01-10 09:06:37 PST
Created attachment 121858 [details] Patch
Yury Semikhatsky
Comment 2 2012-01-11 06:34:44 PST
Comment on attachment 121858 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=121858&action=review > Source/WebCore/inspector/front-end/CompilerSourceMapping.js:273 > + _canonicalizeURL: function(url, baseURL) This is second definition of _canonicalizeURL in this prototype. Please remove the one above. > LayoutTests/http/tests/inspector/resources/source-map.json:4 > +"sourceRoot": "", Why did this line change?
Pavel Podivilov
Comment 3 2012-01-11 07:07:43 PST
Created attachment 122016 [details] Patch
Pavel Podivilov
Comment 4 2012-01-11 07:10:34 PST
(In reply to comment #2) > (From update of attachment 121858 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=121858&action=review > > > Source/WebCore/inspector/front-end/CompilerSourceMapping.js:273 > > + _canonicalizeURL: function(url, baseURL) > > This is second definition of _canonicalizeURL in this prototype. Please remove the one above. Done. > > > LayoutTests/http/tests/inspector/resources/source-map.json:4 > > +"sourceRoot": "", > > Why did this line change? Sources are now relative to source map. In this test source map and sources are in the same directory, so sourceRoot could be empty.
Pavel Podivilov
Comment 5 2012-01-12 03:55:11 PST
Committed r104808: <http://trac.webkit.org/changeset/104808>
Note You need to log in before you can comment on or make changes to this bug.