Bug 75959 – Add RenderStyle::isPositioned() helper method

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Mihnea Ovidenie]

Instead of (style()->position() == AbsolutePosition || style()->position() == FixedPosition) use (style()->isAbsolutelyPositioned()).
Instead of (style()->position() != AbsolutePosition && style()->position() != FixedPosition) use (!style()->isAbsolutelyPositioned()).

[Mihnea Ovidenie]

Created attachment 121847 [details]
Patch

[Tony Chang]

Should we name the function isPositioned() to match the function on RenderObject?

[Mihnea Ovidenie]

(In reply to comment #2)
> Should we name the function isPositioned() to match the function on RenderObject?

I initially thought so, but i decided to name it after looking at the phrase "absolutely positioned element" from http://www.w3.org/TR/CSS2/visuren.html#absolute-positioning.

[Dave Hyatt]

Comment on attachment 121847 [details]
Patch

Agree with Tony. Would prefer isPositioned.

[Mihnea Ovidenie]

Created attachment 122086 [details]
Patch 2

[Tony Chang]

Comment on attachment 122086 [details]
Patch 2

View in context: https://bugs.webkit.org/attachment.cgi?id=122086&action=review

> Source/WebCore/rendering/RenderObject.cpp:629
> +        if (!last->isText() && (last->style()->isPositioned())) {

Nit: Remove extra ()s.

> Source/WebCore/rendering/RenderObject.cpp:669
> +    if (b && !alreadyDirty && markParents && (isText() || (!style()->isPositioned())))

Nit: Remove extra ()s.

[Mihnea Ovidenie]

Created attachment 122184 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 122184 [details]
Patch for landing

Clearing flags on attachment: 122184

Committed r104802: <http://trac.webkit.org/changeset/104802>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.