Bug 75947

Summary: [EFL][WK2] Rename viewObject to viewWidget
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit2Assignee: Ryuan Choi <ryuan.choi>
Status: RESOLVED FIXED    
Severity: Normal CC: g.czajkowski, gyuyoung.kim, mrobinson, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 61838    
Attachments:
Description Flags
Patch
none
Patch none

Description Ryuan Choi 2012-01-10 01:49:45 PST 
Rename viewObject to viewWidget to use WidgetBackingStore which calls viewWidget().
Comment 1 Ryuan Choi 2012-01-10 16:16:20 PST 
Created attachment 121933 [details]
Patch
Comment 2 Gyuyoung Kim 2012-01-10 20:19:34 PST 
Looks good to me. But, I think GTK reviewer also agrees with this patch.
Comment 3 Ryuan Choi 2012-01-10 20:35:56 PST 
Hello martin,

Could you take a look at this patch?
Comment 4 Grzegorz Czajkowski 2012-01-10 23:29:33 PST 
Please change title of the bug: remove -> rename as you write in description in ChangeLog.
Comment 5 Ryuan Choi 2012-01-11 00:13:01 PST 
(In reply to comment #4)
> Please change title of the bug: remove -> rename as you write in description in ChangeLog.

Oops, Sorry about typo.

I'll submit new patch.
Comment 6 Ryuan Choi 2012-01-11 00:14:45 PST 
Created attachment 121988 [details]
Patch
Comment 7 Ryuan Choi 2012-01-11 00:30:01 PST 
Comment on attachment 121988 [details]
Patch

Thank you, martin.

Always, I appreciate your review.
Comment 8 WebKit Review Bot 2012-01-11 02:42:12 PST 
Comment on attachment 121988 [details]
Patch

Clearing flags on attachment: 121988

Committed r104691: <http://trac.webkit.org/changeset/104691>
Comment 9 WebKit Review Bot 2012-01-11 02:42:18 PST 
All reviewed patches have been landed.  Closing bug.