Bug 75947

Summary: [EFL][WK2] Rename viewObject to viewWidget
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit2Assignee: Ryuan Choi <ryuan.choi>
Status: RESOLVED FIXED    
Severity: Normal CC: g.czajkowski, gyuyoung.kim, mrobinson, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 61838    
Attachments:
Description Flags
Patch
none
Patch none

Ryuan Choi
Reported 2012-01-10 01:49:45 PST
Rename viewObject to viewWidget to use WidgetBackingStore which calls viewWidget().
Attachments
Patch (5.25 KB, patch)
2012-01-10 16:16 PST, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Patch (5.28 KB, patch)
2012-01-11 00:14 PST, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryuan Choi
Comment 1 2012-01-10 16:16:20 PST
Created attachment 121933 [details] Patch
Gyuyoung Kim
Comment 2 2012-01-10 20:19:34 PST
Looks good to me. But, I think GTK reviewer also agrees with this patch.
Ryuan Choi
Comment 3 2012-01-10 20:35:56 PST
Hello martin, Could you take a look at this patch?
Grzegorz Czajkowski
Comment 4 2012-01-10 23:29:33 PST
Please change title of the bug: remove -> rename as you write in description in ChangeLog.
Ryuan Choi
Comment 5 2012-01-11 00:13:01 PST
(In reply to comment #4) > Please change title of the bug: remove -> rename as you write in description in ChangeLog. Oops, Sorry about typo. I'll submit new patch.
Ryuan Choi
Comment 6 2012-01-11 00:14:45 PST
Created attachment 121988 [details] Patch
Ryuan Choi
Comment 7 2012-01-11 00:30:01 PST
Comment on attachment 121988 [details] Patch Thank you, martin. Always, I appreciate your review.
WebKit Review Bot
Comment 8 2012-01-11 02:42:12 PST
Comment on attachment 121988 [details] Patch Clearing flags on attachment: 121988 Committed r104691: <http://trac.webkit.org/changeset/104691>
WebKit Review Bot
Comment 9 2012-01-11 02:42:18 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.