| Summary: | [Refactoring] Rename attributes in TestSupplemental.idl to clarify that they are supplemental attributes | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kentaro Hara <haraken> | ||||||
| Component: | Tools / Tests | Assignee: | Kentaro Hara <haraken> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | abarth, darin, japhet, ojan, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 72138 | ||||||||
| Attachments: |
|
||||||||
Created attachment 121803 [details]
Patch
Created attachment 121804 [details]
Patch
Attachment 121803 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/bindings/scripts/test/JS/JSTestInterface.h:60: Extra space before ( in function call [whitespace/parens] [4]
Total errors found: 1 in 11 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 121804 [details] Patch Clearing flags on attachment: 121804 Committed r104639: <http://trac.webkit.org/changeset/104639> All reviewed patches have been landed. Closing bug. |
To make the test result of TestSupplemental.idl readable (i.e. to make it easy to find in {JS,V8,ObjC,GObject,CPP}TestInterface.cpp which attributes originate from TestSupplemental.idl), we should rename the attributes in TestSupplemental.idl, like this: Before: interface [ Supplemental=TestInterface ] TestSupplemental { readonly attribute DOMString str1; attribute DOMString str2; attribute [CustomGetter, CustomSetter] str3; }; After: interface [ Supplemental=TestInterface ] TestSupplemental { readonly attribute DOMString supplementalStr1; attribute DOMString supplementalStr2; attribute [CustomGetter, CustomSetter] supplementalStr3; };