Bug 75921

Summary: [Mac] Accelerate canvas layers with the same logic as accelerating the canvas itself
Product: WebKit Reporter: Matthew Delaney <mdelaney7>
Component: CanvasAssignee: Matthew Delaney <mdelaney7>
Status: RESOLVED FIXED    
Severity: Normal CC: mdelaney7, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch simon.fraser: review+

Matthew Delaney
Reported 2012-01-09 18:14:37 PST
Unblocking our desired lazy allocation of canvas backing stores via http://trac.webkit.org/changeset/96624/trunk introduced the issue of timing problems when asking if a canvas is accelerated or not. For example, when deciding whether or not to set accelerates drawing on a layer we ask if the canvas is accelerated. If the canvas isn't fully created, we might not know if it's accelerated or not, so we default to returning false. So, we can avoid this issue if we just instead accelerate the layer based off the same logic the canvas would use, namely HTMLCanvasElement::shouldAccelerate().
Attachments
Patch (2.44 KB, patch)
2012-01-09 18:22 PST, Matthew Delaney 		no flags
DetailsFormatted DiffDiff
Patch (1.66 KB, patch)
2012-01-09 18:27 PST, Matthew Delaney 		simon.fraser: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Matthew Delaney
Comment 1 2012-01-09 18:22:57 PST
Created attachment 121778 [details] Patch
Matthew Delaney
Comment 2 2012-01-09 18:27:48 PST
Created attachment 121779 [details] Patch
Matthew Delaney
Comment 3 2012-01-10 12:31:03 PST
Committed r104616: <http://trac.webkit.org/changeset/104616>
Note You need to log in before you can comment on or make changes to this bug.