Bug 75915

Summary: CSS transitions should work on the flex property
Product: WebKit Reporter: Tony Chang <tony>
Component: Layout and RenderingAssignee: Tony Chang <tony>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, hyatt, morrita, ojan, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 62048    
Attachments:
Description Flags
Patch
none
Patch none

Description Tony Chang 2012-01-09 17:09:53 PST 
It should be possible to transition from flex() to flex() or from a length to flex() or from flex() to length.
Comment 1 Tony Chang 2012-02-03 17:02:40 PST 
Created attachment 125449 [details]
Patch
Comment 2 Hajime Morrita 2012-02-20 20:58:47 PST 
It looks the test compares the value as a number (float), not a tuple of the numbers. 
Is it intentional? (Disclaimer: I'm not a flexbox expert.)
Comment 3 Tony Chang 2012-02-21 13:51:49 PST 
Comment on attachment 125449 [details]
Patch

The spec is changing so this patch isn't correct anymore. I'll post a new patch when we're ready.
Comment 4 Tony Chang 2012-04-04 13:49:27 PDT 
Created attachment 135668 [details]
Patch
Comment 5 Ojan Vafai 2012-04-04 14:31:27 PDT 
Patch looks good to me. Someone with transitions experience should probably r+ though.
Comment 6 Dean Jackson 2012-04-04 15:50:26 PDT 
Comment on attachment 135668 [details]
Patch

Cool!
Comment 7 WebKit Review Bot 2012-04-04 16:57:51 PDT 
Comment on attachment 135668 [details]
Patch

Clearing flags on attachment: 135668

Committed r113264: <http://trac.webkit.org/changeset/113264>
Comment 8 WebKit Review Bot 2012-04-04 16:57:56 PDT 
All reviewed patches have been landed.  Closing bug.