Bug 75889

Summary: [Qt][WK2] Remove workaround introduced into bug 75470
Product: WebKit Reporter: Hugo Parente Lima <hugo.lima>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Trivial CC: hausmann, kbalazs, vestbo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Hugo Parente Lima
Reported 2012-01-09 14:15:08 PST
Remove QML workaround introduced into bug 75470, clip property is working again. Tested on Qt5 rev. f917ea79ef75917ce9f7d166fd5f8e2b772b9058
Attachments
Patch (1.10 KB, patch)
2012-01-09 14:24 PST, Hugo Parente Lima 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Hugo Parente Lima
Comment 1 2012-01-09 14:24:58 PST
Created attachment 121725 [details] Patch
WebKit Review Bot
Comment 2 2012-01-11 09:49:58 PST
Comment on attachment 121725 [details] Patch Clearing flags on attachment: 121725 Committed r104718: <http://trac.webkit.org/changeset/104718>
WebKit Review Bot
Comment 3 2012-01-11 09:50:12 PST
All reviewed patches have been landed. Closing bug.
Balazs Kelemen
Comment 4 2012-01-12 06:12:18 PST
Well, I think this was a bit too early to remove that since most of us use the qt5 version that we have on the bot and that one would still need the workaround. Normally Ossy updates it weekly, however now it's a bit older because qt5 trunk was buggy. Not a big problem of course, but next time please take this into consideration. I think the most straightforward is to use the bot's qt5 version for development. Anyway, no need to revert this, tomorrow Ossy will update and we can live with that for a day.
Tor Arne Vestbø
Comment 5 2012-01-12 06:32:45 PST
Sorry about that :/
Hugo Parente Lima
Comment 6 2012-01-12 10:05:24 PST
Yep, this is why I did put the hash of Qt5 I used to test it. Anyway my fault for upload the patch too early. P.S.: I did need to update my Qt5 to avoid some segfaults and slowness on QtQuick that were already fixed, this is why I'm using a Qt different from the used on build bots.
Note You need to log in before you can comment on or make changes to this bug.