| Summary: | [Qt][WK2] Remove workaround introduced into bug 75470 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Hugo Parente Lima <hugo.lima> | ||||
| Component: | WebKit Qt | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Trivial | CC: | hausmann, kbalazs, vestbo, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Hugo Parente Lima
2012-01-09 14:15:08 PST
Created attachment 121725 [details]
Patch
Comment on attachment 121725 [details] Patch Clearing flags on attachment: 121725 Committed r104718: <http://trac.webkit.org/changeset/104718> All reviewed patches have been landed. Closing bug. Well, I think this was a bit too early to remove that since most of us use the qt5 version that we have on the bot and that one would still need the workaround. Normally Ossy updates it weekly, however now it's a bit older because qt5 trunk was buggy. Not a big problem of course, but next time please take this into consideration. I think the most straightforward is to use the bot's qt5 version for development. Anyway, no need to revert this, tomorrow Ossy will update and we can live with that for a day. Sorry about that :/ Yep, this is why I did put the hash of Qt5 I used to test it. Anyway my fault for upload the patch too early. P.S.: I did need to update my Qt5 to avoid some segfaults and slowness on QtQuick that were already fixed, this is why I'm using a Qt different from the used on build bots. |