Bug 75866

Summary: [chromium] Add documentation to updater classes
Product: WebKit Reporter: Nat Duca <nduca>
Component: New BugsAssignee: Nat Duca <nduca>
Status: RESOLVED FIXED    
Severity: Normal CC: cc-bugs, danakj, enne, jamesr, reveman, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Nat Duca
Reported 2012-01-09 10:39:05 PST
[chromium] Add documentation to updater classes
Attachments
Patch (5.25 KB, patch)
2012-01-09 11:05 PST, Nat Duca 		no flags
DetailsFormatted DiffDiff
Patch (5.29 KB, patch)
2012-01-09 11:45 PST, Nat Duca 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nat Duca
Comment 1 2012-01-09 11:05:15 PST
Created attachment 121692 [details] Patch
David Reveman
Comment 2 2012-01-09 11:15:14 PST
Comment on attachment 121692 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=121692&action=review Great! Thanks for doing this. > Source/WebCore/platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.h:43 > +// BitmapSkPictureCanvasLayerTextureUpdater and FrameBufferSkPictureCanvasLayerTextureUpdater I'd prefer you changed this comment so that adding a new SkPictureCanvasLayerTextureUpdater subclass doesn't make it inaccurate or require an update to this file. How about making it a bit more general. Maybe just make it "BitmapSkPic../FramebufferSkPic.. are examples of subclasses that implement different..."
Nat Duca
Comment 3 2012-01-09 11:45:28 PST
Created attachment 121705 [details] Patch
David Reveman
Comment 4 2012-01-09 11:51:20 PST
Thanks. LGTM.
WebKit Review Bot
Comment 5 2012-01-09 17:21:30 PST
Comment on attachment 121705 [details] Patch Clearing flags on attachment: 121705 Committed r104522: <http://trac.webkit.org/changeset/104522>
WebKit Review Bot
Comment 6 2012-01-09 17:21:34 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.