Bug 75858

Summary:

Roll Chromium DEPS to last-known good revision

Product:

WebKit

Reporter:

WebKit Review Bot <webkit.review.bot>

Component:

New Bugs

Assignee:

Stephen Chenney <schenney>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, dglazkov, eric, jamesr, schenney

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	webkit.review.bot: commit-queue-

WebKit Review Bot

Reported 2012-01-09 07:54:14 PST

A DEPS roll a day keeps the build break away.

Attachments
Patch (1012 bytes, patch) 2012-01-09 07:54 PST, WebKit Review Bot	no flags	Details Formatted Diff Diff
Patch (943 bytes, patch) 2012-01-09 08:25 PST, Stephen Chenney	no flags	Details Formatted Diff Diff
Patch (943 bytes, patch) 2012-01-09 10:03 PST, Stephen Chenney	webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

WebKit Review Bot

Comment 1 2012-01-09 07:54:27 PST

Created attachment 121673 [details] Patch

Stephen Chenney

Comment 2 2012-01-09 08:25:19 PST

Created attachment 121674 [details] Patch

WebKit Review Bot

Comment 3 2012-01-09 08:37:55 PST

Comment on attachment 121674 [details] Patch Attachment 121674 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11184545

Stephen Chenney

Comment 4 2012-01-09 09:06:37 PST

An update to the dependency requires build/install-build-deps.sh on the linux machines.

Stephen Chenney

Comment 5 2012-01-09 10:03:18 PST

Created attachment 121678 [details] Patch

WebKit Review Bot

Comment 6 2012-01-09 11:00:24 PST

Comment on attachment 121678 [details] Patch Attachment 121678 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11184586

Stephen Chenney

Comment 7 2012-01-09 11:19:20 PST

James, any idea why your change is now causing a build failure?

James Robinson

Comment 8 2012-01-09 11:36:13 PST

I'm not sure. The error makes sense (there is no third_party/WebKit in this configuration according to Adam) but if so then the old include path should not have worked either. There must be some magicks at work here. To unblock the roll, feel free to revert http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/simple_webmimeregistry_impl.h?r1=116554&r2=116553&pathrev=116554 - there's still a forwarding header at Source/WebKit/chromium/public/platform/WebMimeRegistry.h

James Robinson

Comment 9 2012-01-09 11:36:35 PST

I'll take a closer look when I get back to my desk (in a meeting now).

Stephen Chenney

Comment 10 2012-01-09 11:51:56 PST

I can reproduce this locally, so I'll poke around and try to figure out how it was ever working, and why it doesn't now.

Adam Barth

Comment 11 2012-01-09 13:06:46 PST

I chatted with Tony. http://src.chromium.org/viewvc/chrome/trunk/src/webkit/support/setup_third_party.gyp?view=markup needs to be taught about Platform/chromium/public.

James Robinson

Comment 12 2012-01-09 15:41:52 PST

http://codereview.chromium.org/9147017/

James Robinson

Comment 13 2012-01-09 19:31:14 PST

Should be good to roll to http://src.chromium.org/viewvc/chrome?view=rev&revision=116989 or later.

Stephen Chenney

Comment 14 2012-01-10 07:31:57 PST

The issues preventing this was fixed and a roll was done in http://trac.webkit.org/changeset/104540

Note You need to log in before you can comment on or make changes to this bug.