Bug 75837

Summary:

[EFL] Added smart pointers to Ewk_View_Paint_Context class and done minor refactorization.

Product:

WebKit

Reporter:

Tomasz Morawski <t.morawski>

Component:

WebKit EFL

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Added smart pointers to Ewk_View_Paint_Context class and done minor refactorization	rniwa: review+
Fixed ChangeLog	none

Tomasz Morawski

Reported 2012-01-09 02:04:25 PST

Changes: - Changed graphicContext raw pointer to OwnPtr smart pointer. - Changed cr variable name to cairo and making it as RefPtr.

Attachments
Added smart pointers to Ewk_View_Paint_Context class and done minor refactorization (4.61 KB, patch) 2012-01-09 02:05 PST, Tomasz Morawski	rniwa: review+	Details Formatted Diff Diff
Fixed ChangeLog (4.56 KB, patch) 2012-01-10 05:54 PST, Tomasz Morawski	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Tomasz Morawski

Comment 1 2012-01-09 02:05:45 PST

Created attachment 121633 [details] Added smart pointers to Ewk_View_Paint_Context class and done minor refactorization

Raphael Kubo da Costa (:rakuco)

Comment 2 2012-01-09 05:10:20 PST

Looks OK.

Gyuyoung Kim

Comment 3 2012-01-09 05:14:19 PST

Comment on attachment 121633 [details] Added smart pointers to Ewk_View_Paint_Context class and done minor refactorization LGTM too.

Ryosuke Niwa

Comment 4 2012-01-10 00:37:33 PST

Comment on attachment 121633 [details] Added smart pointers to Ewk_View_Paint_Context class and done minor refactorization View in context: https://bugs.webkit.org/attachment.cgi?id=121633&action=review > Source/WebKit/efl/ChangeLog:3 > + [EFL] Added smart pointers to Ewk_View_Paint_Context class and done minor refactorization. Nit: minor "refactoring" > Source/WebKit/efl/ChangeLog:9 > + Changed cr variable name to cairo and making it as RefPtr. Nit: Renamed cr to cairo and made it a RefPtr.

Tomasz Morawski

Comment 5 2012-01-10 05:54:04 PST

Created attachment 121837 [details] Fixed ChangeLog

WebKit Review Bot

Comment 6 2012-01-10 07:18:05 PST

Comment on attachment 121837 [details] Fixed ChangeLog Clearing flags on attachment: 121837 Committed r104568: <http://trac.webkit.org/changeset/104568>

WebKit Review Bot

Comment 7 2012-01-10 07:18:10 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.