Bug 75807

Summary: [Qt] Add support for dynamically enabling and disabling touch mocking in the Qt MiniBrowser
Product: WebKit Reporter: Alexander Færøy <ahf>
Component: WebKit QtAssignee: Alexander Færøy <ahf>
Status: RESOLVED FIXED    
Severity: Normal CC: kenneth, vestbo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Alexander Færøy
Reported 2012-01-08 13:09:57 PST
SSIA.
Attachments
Patch (14.36 KB, patch)
2012-01-08 13:26 PST, Alexander Færøy 		no flags
DetailsFormatted DiffDiff
Patch (14.46 KB, patch)
2012-01-09 04:30 PST, Alexander Færøy 		no flags
DetailsFormatted DiffDiff
Patch (14.38 KB, patch)
2012-01-09 04:58 PST, Alexander Færøy 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alexander Færøy
Comment 1 2012-01-08 13:14:08 PST
Adding Kenneth since him and I discussed this feature at the office.
Alexander Færøy
Comment 2 2012-01-08 13:26:38 PST
Created attachment 121588 [details] Patch
Alexander Færøy
Comment 3 2012-01-08 13:27:31 PST
Adding Tor Arne for review, since he has been hacking on this code recently :-)
Kenneth Rohde Christiansen
Comment 4 2012-01-08 14:28:18 PST
Are you disabling touch events? or merely turning the touch mocking off?
Alexander Færøy
Comment 5 2012-01-08 15:21:24 PST
(In reply to comment #4) > Are you disabling touch events? or merely turning the touch mocking off? Good point. I am merely disabling the mock up on our desktop systems. I will rename the various methods to reflect reality tomorrow :-)
Alexander Færøy
Comment 6 2012-01-09 04:30:49 PST
Created attachment 121644 [details] Patch
Tor Arne Vestbø
Comment 7 2012-01-09 04:39:46 PST
Comment on attachment 121644 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=121644&action=review > Tools/ChangeLog:4 > + [Qt] Add support for dynamically enabling and disabling of Touch Events in the Qt MiniBrowser > + https://bugs.webkit.org/show_bug.cgi?id=75807 disabling _touch mocking_ > Tools/MiniBrowser/qt/MiniBrowserApplication.h:48 > + Q_PROPERTY(bool mockTouchEventsEnabled READ mockTouchEventsEnabled WRITE setMockTouchEventsEnabled NOTIFY mockTouchEventsEnabledChanged) I'd prefer the name touchMockingEnabled throughout
Alexander Færøy
Comment 8 2012-01-09 04:58:10 PST
Created attachment 121647 [details] Patch
WebKit Review Bot
Comment 9 2012-01-09 06:14:20 PST
Comment on attachment 121647 [details] Patch Clearing flags on attachment: 121647 Committed r104455: <http://trac.webkit.org/changeset/104455>
WebKit Review Bot
Comment 10 2012-01-09 06:14:24 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.