Bug 75783

Summary: [Chromium] REGRESSION(r104368): Broke CCLayerTreeHostImplTest.blendingOffWhenDrawingOpaqueLayers
Product: WebKit Reporter: Dmitry Lomov <dslomov>
Component: WebCore Misc.Assignee: W. James MacLean <wjmaclean>
Status: RESOLVED FIXED    
Severity: Normal CC: dslomov, jamesr, webkit.review.bot, wjmaclean
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Dmitry Lomov
Reported 2012-01-07 13:44:27 PST
Build with the break: http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Linux%2032/builds/11207.
Attachments
Patch (2.93 KB, patch)
2012-01-09 11:17 PST, W. James MacLean 		no flags
DetailsFormatted DiffDiff
Patch (3.44 KB, patch)
2012-01-09 11:32 PST, W. James MacLean 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
W. James MacLean
Comment 1 2012-01-09 08:01:39 PST
I think this is my fault, I forgot to update this test as part of my tile culling patch - sorry. The test expectations for this test need to be modified (layer1 should now *not* draw once the opaque layer2 is added, since it is completely occluded by layer2 and thus gets culled). I'll submit a patch this morning, plus add another test case just to confirm that layer1 does draw if layer2 becomes non-opaque.
W. James MacLean
Comment 2 2012-01-09 11:17:38 PST
Created attachment 121697 [details] Patch
W. James MacLean
Comment 3 2012-01-09 11:32:42 PST
Created attachment 121702 [details] Patch
W. James MacLean
Comment 4 2012-01-09 11:33:13 PST
Removed "FAILS_".
James Robinson
Comment 5 2012-01-09 15:04:33 PST
Comment on attachment 121702 [details] Patch R=me. I'm surprised EWS bots don't run webkit_unit_tests, will look into that.
WebKit Review Bot
Comment 6 2012-01-09 16:12:33 PST
Comment on attachment 121702 [details] Patch Clearing flags on attachment: 121702 Committed r104505: <http://trac.webkit.org/changeset/104505>
WebKit Review Bot
Comment 7 2012-01-09 16:12:37 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.