Summary: | TinyMCE: Implement execCommand CreateLink | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Justin Garcia <justin.garcia> | ||||
Component: | HTML Editing | Assignee: | Justin Garcia <justin.garcia> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | ||||||
Priority: | P2 | ||||||
Version: | 420+ | ||||||
Hardware: | Mac | ||||||
OS: | OS X 10.4 | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 6627 | ||||||
Attachments: |
|
Description
Justin Garcia
2006-03-03 14:55:14 PST
I'm going to split UnLink off into it's own bug Created attachment 7066 [details]
patch
Another way to do this would be to pull out the parts of ApplyStyleCommand that apply style to text runs from the parts that do the setup, traversal and cleanup, and make two new classes, PushInlineChangeCommand and ApplyInlineStyleCommand, with CreateLink and ApplyinlineStyleCommand as subclasses of PushInlineChangeCommand. That's more risky and probably not worth the effort unless we think we'll end up needing PushInlineChange in order to implement something else.
Comment on attachment 7066 [details]
patch
Slighly odd way to do it. r=me
|