Bug 75773

Summary: [GTK] Enable requestAnimationFrame in build-webkit
Product: WebKit Reporter: Zan Dobersek <zan>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: mrobinson, rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Zan Dobersek
Reported 2012-01-07 01:28:49 PST
requestAnimationFrame should be enabled in the developer builds for the Gtk port. Currently the timer-based implementation will be used, but should be replaced by a more complete solution (vsync-like). All the relevant layout tests pass, except for a test that utilizes modal dialogs, for which the Gtk port does not have support yet. After the patch lands, clean builds will be required on the bots.
Attachments
Patch (3.11 KB, patch)
2012-01-07 01:41 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2012-01-07 01:41:37 PST
Created attachment 121543 [details] Patch Enable the feature and unskip the passing tests.
Zan Dobersek
Comment 2 2012-01-07 01:45:57 PST
Requesting a review.
WebKit Review Bot
Comment 3 2012-01-07 09:18:30 PST
Comment on attachment 121543 [details] Patch Clearing flags on attachment: 121543 Committed r104386: <http://trac.webkit.org/changeset/104386>
WebKit Review Bot
Comment 4 2012-01-07 09:18:34 PST
All reviewed patches have been landed. Closing bug.
Ryosuke Niwa
Comment 5 2012-01-08 16:09:12 PST
It seems like this patch broke GTK+ builds: http://build.webkit.org/builders/GTK%20Linux%2032-bit%20Release/builds/20601
Zan Dobersek
Comment 6 2012-01-09 00:55:07 PST
(In reply to comment #5) > It seems like this patch broke GTK+ builds: > http://build.webkit.org/builders/GTK%20Linux%2032-bit%20Release/builds/20601 It probably did as a clean build is required. I do not have access to the linked buildbot, though, but I'm sure someone will poke it today.
Note You need to log in before you can comment on or make changes to this bug.