Bug 75759

Summary: Web Inspector: Missing Implementation of Public InspectorDOMAgent Function
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix
none
[PATCH] Removed Unused Method none

Description Joseph Pecoraro 2012-01-06 16:39:47 PST
• InspectorDOMAgent::searchingForNodeInPage is missing an implementation.
• We should also make setSearchingForNodeInPage public.
Comment 1 Joseph Pecoraro 2012-01-06 16:41:38 PST
Created attachment 121521 [details]
[PATCH] Proposed Fix
Comment 2 WebKit Review Bot 2012-01-06 19:10:58 PST
Comment on attachment 121521 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 121521

Committed r104371: <http://trac.webkit.org/changeset/104371>
Comment 3 WebKit Review Bot 2012-01-06 19:11:03 PST
All reviewed patches have been landed.  Closing bug.
Comment 4 Pavel Feldman 2012-01-06 22:40:09 PST
(In reply to comment #0)
> • InspectorDOMAgent::searchingForNodeInPage is missing an implementation.
> • We should also make setSearchingForNodeInPage public.

This change is wrong. I was putting a lot of effort into breaking the: WebKit -> InspectorController -> agents control flows. As of now, only front-end should talk to the agents for control. Acting that way we don't need to sync front-end 'inspect mode' state with backend's 'searching for node'. The getter in the header should have been removed along with its implementation (my oversight), while setter should remain private.
Comment 5 Joseph Pecoraro 2012-01-09 10:55:23 PST
Created attachment 121689 [details]
[PATCH] Removed Unused Method

Reopening based on Pavel's comments. Lets remove the method.
Comment 6 Eric Seidel (no email) 2012-01-09 13:34:43 PST
Comment on attachment 121689 [details]
[PATCH] Removed Unused Method

Cleared review? from attachment 121689 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).
Comment 7 Joseph Pecoraro 2012-01-09 14:02:06 PST
Apparently the bug wasn't reopened? Resetting flags.
Comment 8 Pavel Feldman 2012-01-10 03:22:48 PST
Comment on attachment 121689 [details]
[PATCH] Removed Unused Method

Thanks for fixing this.
Comment 9 WebKit Review Bot 2012-01-10 10:44:55 PST
Comment on attachment 121689 [details]
[PATCH] Removed Unused Method

Clearing flags on attachment: 121689

Committed r104596: <http://trac.webkit.org/changeset/104596>
Comment 10 WebKit Review Bot 2012-01-10 10:45:00 PST
All reviewed patches have been landed.  Closing bug.