| Summary: | Use HashMap<OwnPtr> in SVGAttributeToPropertyMap | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Caio Marcelo de Oliveira Filho <cmarcelo> | ||||
| Component: | New Bugs | Assignee: | Caio Marcelo de Oliveira Filho <cmarcelo> | ||||
| Status: | RESOLVED DUPLICATE | ||||||
| Severity: | Normal | CC: | darin, dbates, mrowe, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 73757 | ||||||
| Attachments: |
|
||||||
|
Description
Caio Marcelo de Oliveira Filho
2012-01-06 13:07:56 PST
Created attachment 121480 [details]
Patch
Comment on attachment 121480 [details] Patch Clearing flags on attachment: 121480 Committed r104362: <http://trac.webkit.org/changeset/104362> All reviewed patches have been landed. Closing bug. This broke the build by introducing a link error. It results in code trying to find __ZN3WTF6OwnPtrINS_6VectorIPKN7WebCore15SVGPropertyInfoELm0EEEEC1ERKS7_ (WTF::OwnPtr<WTF::Vector<WebCore::SVGPropertyInfo const*, 0ul> >::OwnPtr(WTF::OwnPtr<WTF::Vector<WebCore::SVGPropertyInfo const*, 0ul> > const&)). That's a copy-constructor for OwnPtr. OwnPtr can't be copied. Anders tells me that a HashMap with a KeyType whose traits specify emptyValueIsZero=false and whose ValueType is OwnPtr will result in a call to OwnPtr's copy constructor being generated, causing a build failure like this. (In reply to comment #5) > Rolled out in r104369. Thank you Mark for looking into the failure and rolling this patch out. (In reply to comment #6) > Anders tells me that a HashMap with a KeyType whose traits specify emptyValueIsZero=false and whose ValueType is OwnPtr will result in a call to OwnPtr's copy constructor being generated, causing a build failure like this. Thanks for the rollout, Mark. I will look into this. *** This bug has been marked as a duplicate of bug 115653 *** |