Bug 75734

Summary: Use HashMap<OwnPtr> in SVGAttributeToPropertyMap
Product: WebKit Reporter: Caio Marcelo de Oliveira Filho <cmarcelo>
Component: New BugsAssignee: Caio Marcelo de Oliveira Filho <cmarcelo>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: darin, dbates, mrowe, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 73757    
Attachments:
Description Flags
Patch none

Caio Marcelo de Oliveira Filho
Reported 2012-01-06 13:07:56 PST
Use HashMap<OwnPtr> in SVGAttributeToPropertyMap
Attachments
Patch (4.06 KB, patch)
2012-01-06 13:10 PST, Caio Marcelo de Oliveira Filho 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Caio Marcelo de Oliveira Filho
Comment 1 2012-01-06 13:10:14 PST
Created attachment 121480 [details] Patch
WebKit Review Bot
Comment 2 2012-01-06 17:24:23 PST
Comment on attachment 121480 [details] Patch Clearing flags on attachment: 121480 Committed r104362: <http://trac.webkit.org/changeset/104362>
WebKit Review Bot
Comment 3 2012-01-06 17:24:27 PST
All reviewed patches have been landed. Closing bug.
Mark Rowe (bdash)
Comment 4 2012-01-06 18:40:55 PST
This broke the build by introducing a link error. It results in code trying to find __ZN3WTF6OwnPtrINS_6VectorIPKN7WebCore15SVGPropertyInfoELm0EEEEC1ERKS7_ (WTF::OwnPtr<WTF::Vector<WebCore::SVGPropertyInfo const*, 0ul> >::OwnPtr(WTF::OwnPtr<WTF::Vector<WebCore::SVGPropertyInfo const*, 0ul> > const&)). That's a copy-constructor for OwnPtr. OwnPtr can't be copied.
Mark Rowe (bdash)
Comment 5 2012-01-06 18:46:36 PST
Rolled out in r104369.
Mark Rowe (bdash)
Comment 6 2012-01-06 18:47:50 PST
Anders tells me that a HashMap with a KeyType whose traits specify emptyValueIsZero=false and whose ValueType is OwnPtr will result in a call to OwnPtr's copy constructor being generated, causing a build failure like this.
Daniel Bates
Comment 7 2012-01-07 19:13:02 PST
(In reply to comment #5) > Rolled out in r104369. Thank you Mark for looking into the failure and rolling this patch out.
Caio Marcelo de Oliveira Filho
Comment 8 2012-01-09 05:37:21 PST
(In reply to comment #6) > Anders tells me that a HashMap with a KeyType whose traits specify emptyValueIsZero=false and whose ValueType is OwnPtr will result in a call to OwnPtr's copy constructor being generated, causing a build failure like this. Thanks for the rollout, Mark. I will look into this.
Darin Adler
Comment 9 2013-05-07 09:14:42 PDT
*** This bug has been marked as a duplicate of bug 115653 ***
Note You need to log in before you can comment on or make changes to this bug.