Bug 75715

Summary: [Chromium] Crash when using per-tile painting on Windows.
Product: WebKit Reporter: David Reveman <reveman>
Component: WebCore Misc.Assignee: David Reveman <reveman>
Status: RESOLVED FIXED    
Severity: Normal CC: cc-bugs, enne, jamesr, reed, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 77897    
Attachments:
Description Flags
Patch
none
Patch none

Description David Reveman 2012-01-06 10:48:44 PST 
More details here: http://code.google.com/p/chromium/issues/detail?id=107461
Comment 1 David Reveman 2012-01-06 10:51:18 PST 
Temporary patch to avoid the crash until this issue is solved: https://bugs.webkit.org/show_bug.cgi?id=75705
Comment 2 David Reveman 2012-02-03 18:37:45 PST 
Created attachment 125459 [details]
Patch
Comment 3 James Robinson 2012-02-03 19:33:47 PST 
I thought there was work underway in Skia to avoid needing a GDI-backed canvas at all on windows for the SkPicture playback path.  What's the status of that?
Comment 4 David Reveman 2012-02-03 19:55:33 PST 
(In reply to comment #3)
> I thought there was work underway in Skia to avoid needing a GDI-backed canvas at all on windows for the SkPicture playback path.  What's the status of that?

I'm not aware of that but that would be great!

Can we land this patch for now to fix the crash? I'm happy to implement non GDI-backed canvas use if possible in a separate patch.
Comment 5 David Reveman 2012-02-06 13:00:05 PST 
Created attachment 125696 [details]
Patch
Comment 6 David Reveman 2012-02-06 13:08:45 PST 
New patch avoids the PlatformCanvas API completely and this seem to be working fine.
Comment 7 James Robinson 2012-02-06 13:09:05 PST 
Comment on attachment 125696 [details]
Patch

R=me
Comment 8 WebKit Review Bot 2012-02-07 15:30:13 PST 
Comment on attachment 125696 [details]
Patch

Clearing flags on attachment: 125696

Committed r106997: <http://trac.webkit.org/changeset/106997>
Comment 9 WebKit Review Bot 2012-02-07 15:30:18 PST 
All reviewed patches have been landed.  Closing bug.