Bug 75701 – EntryBase::toURL produces wrong URL if path contains special characters

• Component: Platform
• Status: RESOLVED DUPLICATE

[Sergey Ryazanov]

If file name of path contains '#' or '%xx' they get to the URL unescaped. Such an URL doesn't work in XMLHttpRequest or as source of IMG element.

String EntryBase::toURL() has its own code what duplicated AsyncFileSystemChromium::virtualPathToFileSystemURL.

[Sergey Ryazanov]

Created attachment 121548 [details]
Patch

[Eric U.]

Comment on attachment 121548 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=121548&action=review

> Source/WebCore/fileapi/EntryBase.cpp:59
> +    return m_fileSystem->toURL(this);

While this makes the code here smaller, it forces all implementers to basically write the same code.
All that's really missing here is proper escaping of the path.  See https://bugs.webkit.org/show_bug.cgi?id=75049 for the soon-to-be-checked-in fix.

[Eric Seidel (no email)]

Comment on attachment 121548 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=121548&action=review

ericu seems to be tryign to r- this. :)  I'll help him.

> Source/WebCore/ChangeLog:8
> +        No new tests. (OOPS!)

This will fail teh commit-queue.

[Sergey Ryazanov]

*** This bug has been marked as a duplicate of bug 75049 ***