Bug 75681

Summary: [EFL] Fixed displaying buffering progress in the media control.
Product: WebKit Reporter: KwangYong Choi <ky0.choi>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, gyuyoung.kim, kenneth, lucas.de.marchi, rakuco, sw0524.lee, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Linux   
Attachments:
Description Flags
patch none

KwangYong Choi
Reported 2012-01-05 18:45:33 PST
Fixed typo. It is required "rangeRect" instead of "rect".
Attachments
patch (1.37 KB, patch)
2012-07-22 20:07 PDT, KwangYong Choi 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
KwangYong Choi
Comment 1 2012-01-05 22:36:18 PST
It is required "rangeRect" instead of "rect" to display buffering progress properly.
KwangYong Choi
Comment 2 2012-07-22 20:07:28 PDT
Created attachment 153722 [details] patch
Raphael Kubo da Costa (:rakuco)
Comment 3 2012-07-22 21:00:02 PDT
Comment on attachment 153722 [details] patch Does it make any existing test pass?
Chris Dumez
Comment 4 2012-07-22 22:26:41 PDT
Comment on attachment 153722 [details] patch Change looks good but it is likely that some tests need rebasing with this fix. It would be good to do the rebasing in the same patch if it is really needed.
KwangYong Choi
Comment 5 2012-07-24 03:39:15 PDT
I tested "LayoutTests/media/" with/without this patch. But, the test results are same. Each case has 356 failures. This patch does not affects the test results. It's about network load and displaying media control. The buffering progress can be read from JS properly, but display is wrong. I think this patch is required to display buffering progress on media control properly.
KwangYong Choi
Comment 6 2012-07-27 04:19:19 PDT
Should I provide test for this patch? I think it's not easy. :(
Gyuyoung Kim
Comment 7 2012-07-27 10:06:24 PDT
Comment on attachment 153722 [details] patch Could you check if there is difference result on whole layout test. If there is no effect EFL layout test result, looks fine.
Raphael Kubo da Costa (:rakuco)
Comment 8 2012-07-27 17:08:09 PDT
Are you sure no test can be unskipped after this fix?
KwangYong Choi
Comment 9 2012-07-31 00:11:44 PDT
My previous test result was wrong. I should use SHARED_CORE But I did't. So I tested it again. 1. LayoutTests/media/ Test after remove efl/Skipped and wk2/Skipped The results are same. 102 are diff and 1 is flaky. 2. Entire test The results are little bit different. But the different items are not related to media. The changes on this patch is just display rect on media control. So it does not affect to other part.
KwangYong Choi
Comment 10 2012-08-10 03:32:26 PDT
There are no changes in LayoutTests. But it's too hard to make a test for this. If this patch is not applied, then above block to calculate rangeRect is not necessary. I think it need to be merged.
Gyuyoung Kim
Comment 11 2012-08-12 22:34:54 PDT
Comment on attachment 153722 [details] patch If this patch doesn't influence on existing layout test result and there is no unskipped tests, looks good to me.
WebKit Review Bot
Comment 12 2012-08-14 03:13:25 PDT
Comment on attachment 153722 [details] patch Clearing flags on attachment: 153722 Committed r125536: <http://trac.webkit.org/changeset/125536>
WebKit Review Bot
Comment 13 2012-08-14 03:13:30 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.