| Summary: | [EFL] Fixed displaying buffering progress in the media control. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | KwangYong Choi <ky0.choi> | ||||
| Component: | WebKit EFL | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | gyuyoung.kim, gyuyoung.kim, kenneth, lucas.de.marchi, rakuco, sw0524.lee, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Other | ||||||
| OS: | Linux | ||||||
| Attachments: |
|
||||||
|
Description
KwangYong Choi
2012-01-05 18:45:33 PST
It is required "rangeRect" instead of "rect" to display buffering progress properly. Created attachment 153722 [details]
patch
Comment on attachment 153722 [details]
patch
Does it make any existing test pass?
Comment on attachment 153722 [details]
patch
Change looks good but it is likely that some tests need rebasing with this fix. It would be good to do the rebasing in the same patch if it is really needed.
I tested "LayoutTests/media/" with/without this patch. But, the test results are same. Each case has 356 failures. This patch does not affects the test results. It's about network load and displaying media control. The buffering progress can be read from JS properly, but display is wrong. I think this patch is required to display buffering progress on media control properly. Should I provide test for this patch? I think it's not easy. :( Comment on attachment 153722 [details]
patch
Could you check if there is difference result on whole layout test. If there is no effect EFL layout test result, looks fine.
Are you sure no test can be unskipped after this fix? My previous test result was wrong. I should use SHARED_CORE But I did't. So I tested it again. 1. LayoutTests/media/ Test after remove efl/Skipped and wk2/Skipped The results are same. 102 are diff and 1 is flaky. 2. Entire test The results are little bit different. But the different items are not related to media. The changes on this patch is just display rect on media control. So it does not affect to other part. There are no changes in LayoutTests. But it's too hard to make a test for this. If this patch is not applied, then above block to calculate rangeRect is not necessary. I think it need to be merged. Comment on attachment 153722 [details]
patch
If this patch doesn't influence on existing layout test result and there is no unskipped tests, looks good to me.
Comment on attachment 153722 [details] patch Clearing flags on attachment: 153722 Committed r125536: <http://trac.webkit.org/changeset/125536> All reviewed patches have been landed. Closing bug. |