| Summary: | Pixel results from DumpRenderTree and WebKitTestRunner don't match because of colorspace issues | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
| Component: | Tools / Tests | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ap, darin, jonlee, mitz, simon.fraser, tony | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Simon Fraser (smfr)
2012-01-05 15:37:10 PST
Created attachment 121354 [details]
Patch
Comment on attachment 121354 [details] Patch How is this related to bug 72424? *** Bug 72424 has been marked as a duplicate of this bug. *** Comment on attachment 121354 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=121354&action=review > Tools/ChangeLog:3 > + Pixel results from DumpRenderTree and WebKitTestRunner don't match, suffer colorspace issues I think it’s us who suffer. The pixel results are secretly enjoying it. > Tools/DumpRenderTree/mac/PixelDumpSupportMac.mm:55 > + // Creating this bitmap in the device color space should prevent any color conversion when the image of the web view is drawn into it. Can you say “prevents” instead of “should prevent”? Does it not really do what it should do? Wow, what a great thing to do! Wish we had done this years ago. |