| Summary: | webkitpy: clean up test/uri conversion routines | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dirk Pranke <dpranke> | ||||||
| Component: | New Bugs | Assignee: | Dirk Pranke <dpranke> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | abarth, aroben, eric, ojan, rniwa, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Dirk Pranke
2012-01-05 14:15:33 PST
Created attachment 121329 [details]
Patch
(haven't actually tested this on any real ports, just ran the unit tests) Comment on attachment 121329 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=121329&action=review I'm not sure I 100% follow the change, but it looks reasonable. Mostly looks like you're moving code. Looks like these arent' very tested. Can we have more tests of these moved functions? > Tools/Scripts/webkitpy/layout_tests/port/webkit.py:46 > +from webkitpy.common.system.path import cygpath Seems unused? Created attachment 121340 [details]
add more explicit, clearer unit tests, remove unused import
(In reply to comment #3) > (From update of attachment 121329 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=121329&action=review > > I'm not sure I 100% follow the change, but it looks reasonable. Mostly looks like you're moving code. Looks like these arent' very tested. Can we have more tests of these moved functions? > Yup, mostly moving code. The routines were actually well-covered by other tests, but I've added some explicit tests just to be clearer. Disclaimer: I haven't actually run the tests (yet?) on win32 or under cygwin to ensure that they pass there as well. > > Tools/Scripts/webkitpy/layout_tests/port/webkit.py:46 > > +from webkitpy.common.system.path import cygpath > > Seems unused? Yup. removed. Comment on attachment 121340 [details]
add more explicit, clearer unit tests, remove unused import
OK. Thanks.
Committed r104340: <http://trac.webkit.org/changeset/104340> webkitpy.layout_tests.port.mock_drt_unittest.MockChromiumDRTTest has been failing on cr-win since this patch was landed: http://build.webkit.org/builders/Chromium%20Win%20Release%20%28Tests%29/builds/22570/steps/webkitpy-test/logs/stdio looking into it. Bug 75884 filed. |