Bug 75627

Summary: make canvas-lineWidth test pass even if pixel values vary a tiny bit
Product: WebKit Reporter: epoger
Component: Tools / TestsAssignee: epoger
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, deanm, oliver, rniwa, senorblanco, tomhudson, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

epoger
Reported 2012-01-05 09:11:59 PST
In https://bugs.webkit.org/show_bug.cgi?id=75552 ('rebaselining some canvas images'), we noted that this test was reporting failure even though the results were "close enough". So I have modified the test to pass, as long as the results are indeed "close enough".
Attachments
Patch (1.99 KB, patch)
2012-01-05 09:15 PST, epoger 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
epoger
Comment 1 2012-01-05 09:15:00 PST
Created attachment 121287 [details] Patch
epoger
Comment 2 2012-01-05 09:20:51 PST
Tom and Ryosuke- please look at the test change and see if it looks reasonable to you. If so, Ryosuke, please r+.
Tom Hudson
Comment 3 2012-01-05 09:29:22 PST
LGTM. Allowable difference may grow in the future, but we don't have a quantified range, so let's start conservative.
epoger
Comment 4 2012-01-05 13:11:09 PST
rniwa has added a few more people in CC, since he isn't very familiar with canvas stuff...
epoger
Comment 5 2012-01-05 13:13:54 PST
Stephen- could you plese take a look, and r+ if appropriate?
Brent Fulgham
Comment 6 2012-01-05 13:19:50 PST
LGTM. I am strongly in favor of this change, as the WinCairo port often has small differences against the Apple Windows port. This would greatly reduce the amount of custom testing needed to stay in sync.
Stephen White
Comment 7 2012-01-05 13:22:04 PST
I'm ok with this, as long as it's spec-compliant. r=me
WebKit Review Bot
Comment 8 2012-01-06 07:43:13 PST
Comment on attachment 121287 [details] Patch Clearing flags on attachment: 121287 Committed r104293: <http://trac.webkit.org/changeset/104293>
WebKit Review Bot
Comment 9 2012-01-06 07:43:17 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.