Bug 75604

Summary:

All instances of JSC::ArgumentsData appear to be leaked by JSC::Arguments

Product:

WebKit

Reporter:

Mark Rowe (bdash) <mrowe>

Component:

JavaScriptCore

Assignee:

Mark Rowe (bdash) <mrowe>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, fpizlo, mhahnenberg

Priority:

Keywords:

InRadar, Regression

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch v1	fpizlo: review+

Description Mark Rowe (bdash) 2012-01-04 23:22:02 PST

JSC::Arguments has an OwnPtr<ArgumentsData> as a member but the destructor is never invoked due to Arguments being a JSCell subclass. This means that the ArgumentsData instances are never deallocated.

Comment 1 Mark Rowe (bdash) 2012-01-04 23:26:32 PST

Created attachment 121221 [details]
Patch v1

From my reading of the code, this looks like the correct fix. Testing shows that the leaks go away. I'm taking that as a positive sign!

Comment 2 Filip Pizlo 2012-01-04 23:28:46 PST

Comment on attachment 121221 [details]
Patch v1

I concur.  Looks good.

Comment 3 Filip Pizlo 2012-01-04 23:29:38 PST

<rdar://problem/10647206>

Comment 4 Mark Rowe (bdash) 2012-01-04 23:39:58 PST

Fixed in r104119.