Bug 75603

Summary: InspectorStyleSheet: Avoid cloning CSSRuleLists.
Product: WebKit Reporter: Andreas Kling <kling>
Component: Web Inspector (Deprecated)Assignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: pfeldman, rniwa, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Andreas Kling
Reported 2012-01-04 22:45:23 PST
InspectorStyleSheet currently uses CSSRuleList::create(styleSheet, omitCharsetRules = true), and the omitCharsetRules forces the CSSRuleList constructor to clone the stylesheet's rule list. All rules other than style-rules and rules with internal rule lists are discarded by InspectorStyleSheet anyway, so we don't need to filter out charset rules beforehand.
Attachments
Patch (1.96 KB, patch)
2012-01-04 22:49 PST, Andreas Kling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2012-01-04 22:49:19 PST
Created attachment 121219 [details] Patch
Ryosuke Niwa
Comment 2 2012-01-04 22:55:56 PST
Comment on attachment 121219 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=121219&action=review > Source/WebCore/ChangeLog:16 > + Don't pass omitCharsetRules=true to the CSSRuleList constructor. Don't think we normally indent here.
Andreas Kling
Comment 3 2012-01-05 02:20:28 PST
Comment on attachment 121219 [details] Patch Clearing flags on attachment: 121219 Committed r104131: <http://trac.webkit.org/changeset/104131>
Andreas Kling
Comment 4 2012-01-05 02:20:37 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.