Bug 75547

Summary:

[chromium] Use scratch textures in skia/Ganesh for canvas backing stores.

Product:

WebKit

Reporter:

Stephen White <senorblanco>

Component:

Canvas

Assignee:

Stephen White <senorblanco>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

bsalomon, cc-bugs, jamesr, kbr, mdelaney7, schenney, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	senorblanco: review-

Stephen White

Reported 2012-01-04 07:40:43 PST

This improves performance when canvas backing stores are re-created at the same res, since Ganesh will retrieve them from cache rather than performing a glTexImage2D().

Attachments
Patch (2.97 KB, patch) 2012-01-04 07:54 PST, Stephen White	senorblanco: review-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Stephen White

Comment 1 2012-01-04 07:54:38 PST

Created attachment 121111 [details] Patch

Kenneth Russell

Comment 2 2012-01-04 12:05:51 PST

Comment on attachment 121111 [details] Patch Looks good to me as long as it's been tested. You're sure that this code path in Ganesh won't change GL state in a way that might confuse the caller?

Brian Salomon

Comment 3 2012-01-04 12:21:15 PST

I think we will want to handle the recycling of textures on behalf of the client transparently in skia without changing webkit. This change will work but every canvas will count against the cache budget for skia's internally created textures.

Stephen White

Comment 4 2012-01-04 12:22:22 PST

Comment on attachment 121111 [details] Patch After discussion w/Brian, we'll try this another way.

Note You need to log in before you can comment on or make changes to this bug.