| Summary: | DFG: The assertion that a double-voted variable cannot become double-unvoted is wrong | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||||
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | ||||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
|
Description
Filip Pizlo
2012-01-03 20:42:32 PST
Created attachment 121048 [details]
the patch
I'm going to try to reduce a test case for this, though this may be hard.
Created attachment 121059 [details]
the patch, with test
Test needs review.
Comment on attachment 121059 [details] the patch, with test View in context: https://bugs.webkit.org/attachment.cgi?id=121059&action=review > LayoutTests/ChangeLog:3 > + DFG: The assertion that a double-voted variable cannot becom double-unvoted is wrong Typo: 'becom' > LayoutTests/ChangeLog:10 > + that become either double, or integer, or mix or double and integer only after multiple Typo: 'or mix or double...' Test rubber stamped by Andy Estes. Will do a full testing run and then land. (In reply to comment #3) > (From update of attachment 121059 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=121059&action=review > > > LayoutTests/ChangeLog:3 > > + DFG: The assertion that a double-voted variable cannot becom double-unvoted is wrong > > Typo: 'becom' > > > LayoutTests/ChangeLog:10 > > + that become either double, or integer, or mix or double and integer only after multiple > > Typo: 'or mix or double...' Fixed and fixed. Thanks! Comment on attachment 121059 [details]
the patch, with test
r=me for the test if you fix the ChangeLog typos. The code change is covered by Gavin's review.
Landed in http://trac.webkit.org/changeset/104016 |