Bug 75491 – Plumbs WebLayerTreeViewImpl::didCompleteSwapBuffers

• Component: New Bugs
• Status: RESOLVED INVALID

[Peter Kotwicz]

Plubs WebLayerTreeViewImpl::didCompleteSwapBuffers

[Peter Kotwicz]

Created attachment 120991 [details]
Patch

[Peter Kotwicz]

Did not plumb ::didCommitAndDrawFrame as it is not needed yet

[Peter Kotwicz]

This is the missing piece for the multithreaded compositor to work with accelerated content. Once webgraphicscontext3d_command_buffer_impl is used in the browser compositor, accelerated content should work with the multithreaded compositor

[Antoine Labour]

LGTM, but you'll need the chrome-side change to land first before this can go in.

[James Robinson]

Comment on attachment 120991 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=120991&action=review

> Source/WebKit/chromium/public/platform/WebLayerTreeViewClient.h:52
> +    // Signals that a swap buffers has been completed.
> +    virtual void didCompleteSwapBuffers() = 0;
> +

where's the chromium-side implementation of this?

[WebKit Review Bot]

Please wait for approval from [e-mail] before submitting because this patch contains changes to the Chromium public API.

[Peter Kotwicz]

Ping. The chromium side has landed.
Chromium side:
http://codereview.chromium.org/9014030

[James Robinson]

The comment is phrased oddly and could be improved (I don't think a "swap buffers" is a phrase)

[Peter Kotwicz]

James, do you have suggestions for the comment? I am pulling a blank.
I am thinking: "Signals that a new color buffer has been posted to the native window."(In reply to comment #8)
> The comment is phrased oddly and could be improved (I don't think a "swap buffers" is a phrase)

[Anders Carlsson]

Chromium is gone.