Summary: | [WK2] WebPageProxy::activeURL should return unreachableURL() when it's not empty | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||||
Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | andersca, ap, dglazkov, gustavo, mitz, plaes, sam, sullivan, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Linux | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 75433 | ||||||||
Attachments: |
|
Description
Carlos Garcia Campos
2012-01-03 01:26:03 PST
Created attachment 120918 [details]
Patch
(In reply to comment #1) > Created an attachment (id=120918) [details] > Patch Could you also remove the FIXME from WebViewTest::replaceContent in Source/WebKit2/UIProcess/API/gtk/tests/WebViewTest.cpp ? (In reply to comment #2) > (In reply to comment #1) > > Created an attachment (id=120918) [details] [details] > > Patch > > Could you also remove the FIXME from WebViewTest::replaceContent in Source/WebKit2/UIProcess/API/gtk/tests/WebViewTest.cpp ? Sure Created attachment 121255 [details] Updated patch It removes the workaround used to fix unit tests in r104129 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Comment on attachment 121255 [details] Updated patch Attachment 121255 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11143062 New failing tests: http/tests/inspector/network/download.html ping, could someone review this patch please? Comment on attachment 121255 [details]
Updated patch
LGTM
Committed r110834: <http://trac.webkit.org/changeset/110834> |