Bug 75457

Summary: [WK2] Share cairo specific codes with EFL port.
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit2Assignee: Ryuan Choi <ryuan.choi>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, mrobinson, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 61838    
Attachments:
Description Flags
Patch none

Ryuan Choi
Reported 2012-01-02 18:48:38 PST
Change PLATFORM(GTK) to USE(CAIRO) in WebGraphicsContext{h,cpp} to share with EFL port.
Attachments
Patch (2.44 KB, patch)
2012-01-02 20:16 PST, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryuan Choi
Comment 1 2012-01-02 20:16:10 PST
Created attachment 120908 [details] Patch
Ryuan Choi
Comment 2 2012-01-11 16:32:41 PST
Add bfulgham to CCs to know whether this patch is valid for the WinCairo port. Should I add `&& !PLATFORM(WIN_CAIRO)` ?
Brent Fulgham
Comment 3 2012-01-11 16:42:21 PST
Comment on attachment 120908 [details] Patch These changes are all perfect for WinCairo. No need to add the PLATFORM(WIN_CAIRO) stuff here, as these are all applicable to the port.
Brent Fulgham
Comment 4 2012-01-11 16:43:10 PST
Comment on attachment 120908 [details] Patch In fact, this change looks great as it is. Please apply it.
Ryuan Choi
Comment 5 2012-01-11 16:48:49 PST
Comment on attachment 120908 [details] Patch Thank you for the review.
WebKit Review Bot
Comment 6 2012-01-11 17:29:44 PST
Comment on attachment 120908 [details] Patch Clearing flags on attachment: 120908 Committed r104776: <http://trac.webkit.org/changeset/104776>
WebKit Review Bot
Comment 7 2012-01-11 17:29:48 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.