Bug 75457

Summary: [WK2] Share cairo specific codes with EFL port.
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit2Assignee: Ryuan Choi <ryuan.choi>
Severity: Normal CC: bfulgham, mrobinson, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 61838    
Description Flags
Patch none

Description Ryuan Choi 2012-01-02 18:48:38 PST
Change PLATFORM(GTK) to USE(CAIRO) in WebGraphicsContext{h,cpp} to share with EFL port.
Comment 1 Ryuan Choi 2012-01-02 20:16:10 PST
Created attachment 120908 [details]
Comment 2 Ryuan Choi 2012-01-11 16:32:41 PST
Add bfulgham to CCs to know whether this patch is valid for the WinCairo port.

Should I add `&& !PLATFORM(WIN_CAIRO)` ?
Comment 3 Brent Fulgham 2012-01-11 16:42:21 PST
Comment on attachment 120908 [details]

These changes are all perfect for WinCairo.  No need to add the PLATFORM(WIN_CAIRO) stuff here, as these are all applicable to the port.
Comment 4 Brent Fulgham 2012-01-11 16:43:10 PST
Comment on attachment 120908 [details]

In fact, this change looks great as it is.  Please apply it.
Comment 5 Ryuan Choi 2012-01-11 16:48:49 PST
Comment on attachment 120908 [details]

Thank you for the review.
Comment 6 WebKit Review Bot 2012-01-11 17:29:44 PST
Comment on attachment 120908 [details]

Clearing flags on attachment: 120908

Committed r104776: <http://trac.webkit.org/changeset/104776>
Comment 7 WebKit Review Bot 2012-01-11 17:29:48 PST
All reviewed patches have been landed.  Closing bug.