Bug 75424

Summary: [EFL] Remove whitespace/declaration style exception
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: Tools / TestsAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, levin, ojan, rakuco, rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Gyuyoung Kim
Reported 2012-01-01 18:57:09 PST
EFL port doesn't violate whitespace/declaration coding style rule. So, this patch remove it from checker.py file.
Attachments
Patch (4.73 KB, patch)
2012-01-01 19:09 PST, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (4.53 KB, patch)
2012-01-01 22:06 PST, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2012-01-01 19:09:56 PST
Created attachment 120853 [details] Patch
Raphael Kubo da Costa (:rakuco)
Comment 2 2012-01-01 20:10:22 PST
Looks OK, even though the changes to FrameLoaderClientEfl.cpp and ewk_frame.cpp aren't really whitespace/declaration fixes (but rather build/include_order and whitespace/braces, respectively).
Gyuyoung Kim
Comment 3 2012-01-01 20:48:55 PST
(In reply to comment #2) > Looks OK, even though the changes to FrameLoaderClientEfl.cpp and ewk_frame.cpp aren't really whitespace/declaration fixes (but rather build/include_order and whitespace/braces, respectively). Yes, right. when I test this patch on efl directory, there are some other style errors. So, I fix them together because they are trivial errors. I think it is better to fix on this bug together.
Gyuyoung Kim
Comment 4 2012-01-01 22:06:18 PST
Created attachment 120863 [details] Patch
Gyuyoung Kim
Comment 5 2012-01-01 22:08:03 PST
I miss one thing. EWebLauncher and MiniBrowser are EFL simple application. So, I think they need to use EFL coding style continually. So, I keep *whitespace/declaration* exception for EWebLauncher and MiniBrowser.
Raphael Kubo da Costa (:rakuco)
Comment 6 2012-01-02 04:43:18 PST
Informal r+.
WebKit Review Bot
Comment 7 2012-01-02 13:09:49 PST
Comment on attachment 120863 [details] Patch Clearing flags on attachment: 120863 Committed r103911: <http://trac.webkit.org/changeset/103911>
WebKit Review Bot
Comment 8 2012-01-02 13:09:54 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.