Bug 75420 – [CMake] Clean up some cruft from wtf's CMakeLists.txt

• Component: New Bugs
• Status: RESOLVED FIXED

[Raphael Kubo da Costa (:rakuco)]

[CMake] Clean up some cruft from wtf's CMakeLists.txt

[Raphael Kubo da Costa (:rakuco)]

Created attachment 120849 [details]
Patch

[Daniel Bates]

Comment on attachment 120849 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=120849&action=review

> Source/JavaScriptCore/ChangeLog:3
> +        [CMake] Clean up some cruft from wtf's CMakeLists.txt

Nit: wtf => WTF

> Source/JavaScriptCore/wtf/CMakeLists.txt:-210
> -    "${CMAKE_SOURCE_DIR}/Source/ThirdParty"

Removing this line will break the build for ports that use the Mersenne Twister pseudorandom number generator, including the WinCE and BlackBerry ports. Notice the file Souece/ThirdParty/mt19937.ar.c is included in wtf/RandomNumber.cpp.

[Raphael Kubo da Costa (:rakuco)]

Created attachment 120852 [details]
Second attempt

[Daniel Bates]

Comment on attachment 120852 [details]
Second attempt

Can you elaborate on how you came to the decision to move the include directory ${CMAKE_SOURCE_DIR}/Source/ThirdParty from Source/JavaScriptCore/wtf/CMakeLists.txt to Platform{BlackBerry, WinCE.cmake}?

[Raphael Kubo da Costa (:rakuco)]

(In reply to comment #4)
> (From update of attachment 120852 [details])
> Can you elaborate on how you came to the decision to move the include directory ${CMAKE_SOURCE_DIR}/Source/ThirdParty from Source/JavaScriptCore/wtf/CMakeLists.txt to Platform{BlackBerry, WinCE.cmake}?

You had previously mentioned BlackBerry and WinCE needed ${THIRDPARTY_DIR} for the Mersenne Twister PRNG, so I moved it to the respective platform files instead of including it for all ports which use CMake.

[Raphael Kubo da Costa (:rakuco)]

Created attachment 121693 [details]
Third third is a charm: always add THIRDPARTY_DIR

[Raphael Kubo da Costa (:rakuco)]

Committed r104468: <http://trac.webkit.org/changeset/104468>