Bug 75364 – Use HashMap<OwnPtr> in RenderSVGResourceGradient

• Component: New Bugs
• Status: RESOLVED FIXED

[Caio Marcelo de Oliveira Filho]

Use HashMap<OwnPtr> in RenderSVGResourceGradient

[Caio Marcelo de Oliveira Filho]

Created attachment 120762 [details]
Patch

[Caio Marcelo de Oliveira Filho]

Committed r103905: <http://trac.webkit.org/changeset/103905>

[Andrew Wilson]

We are seeing valgrind errors on the chromium bots that seem to be caused by this change - as an example:


   <insert_a_suppression_name_here>
   Memcheck:Uninitialized
   fun:_ZN7WebCore16SkPMColorToColorEj
   fun:_ZN7WebCore11ImageBuffer27platformTransformColorSpaceERKN3WTF6VectorIiLm0EEE
   fun:_ZN7WebCore11ImageBuffer19transformColorSpaceENS_10ColorSpaceES1_
   fun:_ZN7WebCore23RenderSVGResourceFilter17postApplyResourceEPNS_12RenderObjectERPNS_15GraphicsContextEtPKNS_4PathEPKNS_14RenderSVGShapeE
   fun:_ZN7WebCore16SVGRenderSupport22finishRenderSVGContentEPNS_12RenderObjectERNS_9PaintInfoEPNS_15GraphicsContextE
   fun:_ZN7WebCore14RenderSVGShape5paintERNS_9PaintInfoERKNS_8IntPointE
   fun:_ZN7WebCore9RenderBox5paintERNS_9PaintInfoERKNS_8IntPointE
   fun:_ZN7WebCore13RenderSVGRoot5paintERNS_9PaintInfoERKNS_8IntPointE
   fun:_ZN7WebCore9InlineBox5paintERNS_9PaintInfoERKNS_8IntPointEii
   fun:_ZN7WebCore13InlineFlowBox5paintERNS_9PaintInfoERKNS_8IntPointEii
   fun:_ZN7WebCore13RootInlineBox5paintERNS_9PaintInfoERKNS_8IntPointEii
   fun:_ZNK7WebCore17RenderLineBoxList5paintEPNS_20RenderBoxModelObjectERNS_9PaintInfoERKNS_8IntPointE
   fun:_ZN7WebCore11RenderBlock13paintContentsERNS_9PaintInfoERKNS_8IntPointE
   fun:_ZN7WebCore11RenderBlock11paintObjectERNS_9PaintInfoERKNS_8IntPointE
   fun:_ZN7WebCore11RenderBlock5paintERNS_9PaintInfoERKNS_8IntPointE
   fun:_ZN7WebCore11RenderBlock13paintChildrenERNS_9PaintInfoERKNS_8IntPointE
   fun:_ZN7WebCore11RenderBlock13paintContentsERNS_9PaintInfoERKNS_8IntPointE
   fun:_ZN7WebCore11RenderBlock11paintObjectERNS_9PaintInfoERKNS_8IntPointE
   fun:_ZN7WebCore11RenderBlock5paintERNS_9PaintInfoERKNS_8IntPointE
   fun:_ZN7WebCore11RenderBlock13paintChildrenERNS_9PaintInfoERKNS_8IntPointE
   fun:_ZN7WebCore11RenderBlock13paintContentsERNS_9PaintInfoERKNS_8IntPointE
   fun:_ZN7WebCore11RenderBlock11paintObjectERNS_9PaintInfoERKNS_8IntPointE
}

Does this seem related?

[Caio Marcelo de Oliveira Filho]

(In reply to comment #3)
> Does this seem related?

Doesn't seem directly related.

Which tests were run? How can I reproduce them in my machine (I have WebKit checkout compiled with --chromium)?

I read some instructions about tools/valgrind but couldn't find it inside the WebKit tree (even after running update-webkit --chromium).

[Andrew Wilson]

It's not really possible to run valgrind from a webkit tree. OK, let's keep this resolved as "fixed" for now, and we'll see if the problem recurs or goes away in future valgrind build cycles - I'm not convinced that it's due to this change anyway).