Bug 75346

Summary: Use HashMap<OwnPtr> for SourceProviderCache items
Product: WebKit Reporter: Caio Marcelo de Oliveira Filho <cmarcelo>
Component: New BugsAssignee: Caio Marcelo de Oliveira Filho <cmarcelo>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, dbates, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Caio Marcelo de Oliveira Filho
Reported 2011-12-29 05:26:17 PST
Use HashMap<OwnPtr> for SourceProviderCache items
Attachments
Patch (3.20 KB, patch)
2011-12-29 05:26 PST, Caio Marcelo de Oliveira Filho 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Caio Marcelo de Oliveira Filho
Comment 1 2011-12-29 05:26:53 PST
Created attachment 120735 [details] Patch
Caio Marcelo de Oliveira Filho
Comment 2 2011-12-29 05:30:57 PST
I couldn't make it work just with the forward declaration to SourceProviderCacheItem. I thought having the destructor for SourceProviderCache defined in the cpp would be enough, but in this case isn't. I think that's because the HashMap containing the OwnPtrs is a member itself -- c.f. the PageGroup that have the maps inside OwnPtrs. But I might be missing something.
Alexis Menard (darktears)
Comment 3 2012-01-02 12:47:19 PST
Comment on attachment 120735 [details] Patch LGTM.
WebKit Review Bot
Comment 4 2012-01-06 12:20:42 PST
Comment on attachment 120735 [details] Patch Clearing flags on attachment: 120735 Committed r104318: <http://trac.webkit.org/changeset/104318>
WebKit Review Bot
Comment 5 2012-01-06 12:20:46 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.