Bug 75327

Summary:

Use HashMap<OwnPtr> in OriginAccessMap

Product:

WebKit

Reporter:

Caio Marcelo de Oliveira Filho <cmarcelo>

Component:

New Bugs

Assignee:

Caio Marcelo de Oliveira Filho <cmarcelo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

atwilson, kling

Priority:

P2

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

75328

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	kling: review+

Caio Marcelo de Oliveira Filho

Reported 2011-12-28 14:35:15 PST

Use HashMap<OwnPtr> in OriginAccessMap

Attachments
Patch (3.38 KB, patch) 2011-12-28 14:36 PST, Caio Marcelo de Oliveira Filho	no flags	Details Formatted Diff Diff
Patch (3.38 KB, patch) 2011-12-29 04:47 PST, Caio Marcelo de Oliveira Filho	kling: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Caio Marcelo de Oliveira Filho

Comment 1 2011-12-28 14:36:06 PST

Created attachment 120700 [details] Patch

Caio Marcelo de Oliveira Filho

Comment 2 2011-12-28 14:44:10 PST

Committed r103782: <http://trac.webkit.org/changeset/103782>

Andrew Wilson

Comment 3 2011-12-28 15:31:40 PST

This patch seemed to cause crashes on the chromium bots: 2011-12-28 15:03:42,804 2698 single_test_runner.py:194 DEBUG worker/0 Stacktrace for http/tests/xmlhttprequest/origin-whitelisting-removal.html: CONSOLE MESSAGE: line 1: XMLHttpRequest cannot load http://localhost:8000/xmlhttprequest/resources/get.txt. Origin http://127.0.0.1:8000 is not allowed by Access-Control-Allow-Origin. base::debug::StackTrace::StackTrace() [0x5b6fee] base::(anonymous namespace)::StackDumpSignalHandler() [0x59fe39] 0x7ffd1156eaf0 WebCore::SecurityPolicy::removeOriginAccessWhitelistEntry() [0xd8eaea] WebKit::WebSecurityPolicy::removeOriginAccessWhitelistEntry() [0x46c50a] LayoutTestController::removeOriginAccessWhitelistEntry() [0x4335e0] CppBoundClass::invoke() [0x424548] WebCore::npObjectInvokeImpl() [0xb632e1] WebCore::npObjectMethodHandler() [0xb633ce] v8::internal::Builtin_HandleApiCall() [0x67d11d] 0x24360d20420e 2011-12-28 15:03:42,805 2673 printing.py:462 INFO http/tests/xmlhttprequest/origin-whitelisting-removal.html -> unexpected DumpRenderTree crash 2011-12-28 15:03:42,806 2698 worker.py:158 DEBUG worker/0 killing driver 2011-12-28 15:03:42,806 2698 worker.py:180 DEBUG worker/0 http/tests/xmlhttprequest/origin-whitelisting-removal.html failed: 2011-12-28 15:03:42,806 2698 worker.py:182 DEBUG worker/0 DumpRenderTree crashed

Caio Marcelo de Oliveira Filho

Comment 4 2011-12-29 04:47:24 PST

Reopening to attach new patch.

Caio Marcelo de Oliveira Filho

Comment 5 2011-12-29 04:47:28 PST

Created attachment 120732 [details] Patch

Caio Marcelo de Oliveira Filho

Comment 6 2011-12-29 04:50:22 PST

Comment on attachment 120732 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=120732&action=review > Source/WebCore/page/SecurityPolicy.cpp:-164 > - delete list; I've missed removing this delete in the first patch.

Caio Marcelo de Oliveira Filho

Comment 7 2011-12-29 09:53:50 PST

Committed r103807: <http://trac.webkit.org/changeset/103807>

Note You need to log in before you can comment on or make changes to this bug.