Bug 75292

Summary: [EFL] Move function to get dpi to the WebCore/platform/efl/EflScreenUtilities.cpp.
Product: WebKit Reporter: Eunmi Lee <enmi.lee>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch for DPI
none
patch for DPI none

Eunmi Lee
Reported 2011-12-27 22:58:43 PST
Move ewk_util_dpi_get() function in the ewk_util.cpp to the WebCore/platform/efl/EflUtilities.cpp in order to use it in the WebKit2. The function's name is changed to getDPI().
Attachments
patch for DPI (6.86 KB, patch)
2011-12-27 23:01 PST, Eunmi Lee 		no flags
DetailsFormatted DiffDiff
patch for DPI (6.98 KB, patch)
2011-12-28 18:47 PST, Eunmi Lee 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eunmi Lee
Comment 1 2011-12-27 23:01:39 PST
Created attachment 120637 [details] patch for DPI
Gyuyoung Kim
Comment 2 2011-12-27 23:28:33 PST
LGTM.
Raphael Kubo da Costa (:rakuco)
Comment 3 2011-12-28 04:34:17 PST
Comment on attachment 120637 [details] patch for DPI Looks OK; calling something 'utils', 'misc' or 'utilities' is something I'd like to avoid, though. As there is EflKeyboardUtilities.cpp, how about calling EflUtilities.cpp EflScreenUtilities.cpp?
Eunmi Lee
Comment 4 2011-12-28 18:06:12 PST
(In reply to comment #3) > (From update of attachment 120637 [details]) > Looks OK; calling something 'utils', 'misc' or 'utilities' is something I'd like to avoid, though. As there is EflKeyboardUtilities.cpp, how about calling EflUtilities.cpp EflScreenUtilities.cpp? I agree with you :) It's better to use EflScreenUtilities.cpp as EflKeyboardUtilities.cpp.
Eunmi Lee
Comment 5 2011-12-28 18:47:32 PST
Created attachment 120712 [details] patch for DPI Rename EflUtilities.cpp to EflUtilities.h
Eunmi Lee
Comment 6 2011-12-28 18:48:03 PST
(In reply to comment #5) > Created an attachment (id=120712) [details] > patch for DPI > > Rename EflUtilities.cpp to EflUtilities.h Rename EflUtilities.cpp and EflUtilities.h to EflScreenUtilities.*
Gyuyoung Kim
Comment 7 2011-12-28 20:52:58 PST
Though I'm a little concern how many utilities files will be added, looks good. :-)
WebKit Review Bot
Comment 8 2012-01-01 22:47:01 PST
Comment on attachment 120712 [details] patch for DPI Clearing flags on attachment: 120712 Committed r103891: <http://trac.webkit.org/changeset/103891>
WebKit Review Bot
Comment 9 2012-01-01 22:47:06 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.