Bug 75259

Summary: Web Inspector: complete annotating SDK component.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch yurys: review+

Pavel Feldman
Reported 2011-12-27 09:48:01 PST
Patch to follow.
Attachments
Patch (23.64 KB, patch)
2011-12-27 09:50 PST, Pavel Feldman 		yurys: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2011-12-27 09:50:03 PST
Created attachment 120597 [details] Patch
Yury Semikhatsky
Comment 2 2011-12-27 11:30:35 PST
Comment on attachment 120597 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=120597&action=review > Source/WebCore/inspector/front-end/NetworkManager.js:241 > + if (!response) Why did it change?
Pavel Feldman
Comment 3 2011-12-28 01:25:43 PST
Comment on attachment 120597 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=120597&action=review >> Source/WebCore/inspector/front-end/NetworkManager.js:241 >> + if (!response) > > Why did it change? It was wrong to require that the response is defined in the _isNull check. In fact, we are now sending 0 for null responses on the backend.
Pavel Feldman
Comment 4 2011-12-28 01:31:58 PST
Committed r103759: <http://trac.webkit.org/changeset/103759>
Note You need to log in before you can comment on or make changes to this bug.