Bug 75229

Summary: Web Inspector: Extract FileEditor from ScriptsPanel.
Product: WebKit Reporter: Vsevolod Vlasov <vsevik>
Component: Web Inspector (Deprecated)Assignee: Vsevolod Vlasov <vsevik>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 75093    
Attachments:
Description Flags
Patch pfeldman: review+

Description Vsevolod Vlasov 2011-12-26 10:49:44 PST 
Extract FileEditor from ScriptsPanel.
Comment 1 Vsevolod Vlasov 2011-12-26 10:59:15 PST 
Created attachment 120557 [details]
Patch
Comment 2 Pavel Feldman 2011-12-26 11:23:37 PST 
Comment on attachment 120557 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=120557&action=review

Please rename new interface and a class prior to landing.

> Source/WebCore/inspector/front-end/ScriptsPanel.js:1073
> +WebInspector.ScriptsPanel.FileEditor = function() { }

FileEditor is not a great name for this. We have TextViewer (that was renamed from TextEditor when we stripped editing capabilities that should be renamed back). This looks like a WebInspector.EditorContainer to me.

> Source/WebCore/inspector/front-end/UISourceCode.js:145
> +        if (!this._fileName)

What if fileName is "" ?
Comment 3 Vsevolod Vlasov 2011-12-26 11:47:30 PST 
Committed r103690: <http://trac.webkit.org/changeset/103690>