Bug 75206

Summary:

Yarr: Avoid copying vectors in CharacterClassConstructor.

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

JavaScriptCore

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Proposed patch	darin: review+, webkit.review.bot: commit-queue-

Description Andreas Kling 2011-12-25 12:00:39 PST

CharacterClassConstructor::charClass() gets a little hot (1.2%) when loading twitter feeds, and we can avoid the copy altogether by using Vector::swap().

Comment 1 Andreas Kling 2011-12-25 12:01:42 PST

Created attachment 120512 [details]
Proposed patch

Comment 2 WebKit Review Bot 2011-12-25 12:54:05 PST

Comment on attachment 120512 [details]
Proposed patch

Attachment 120512 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11027710

New failing tests:
http/tests/inspector/resource-tree/resource-tree-document-url.html

Comment 3 Andreas Kling 2011-12-25 13:21:20 PST

Committed r103672: <http://trac.webkit.org/changeset/103672>