Bug 75206

Summary: Yarr: Avoid copying vectors in CharacterClassConstructor.
Product: WebKit Reporter: Andreas Kling <kling>
Component: JavaScriptCoreAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch darin: review+, webkit.review.bot: commit-queue-

Andreas Kling
Reported 2011-12-25 12:00:39 PST
CharacterClassConstructor::charClass() gets a little hot (1.2%) when loading twitter feeds, and we can avoid the copy altogether by using Vector::swap().
Attachments
Proposed patch (1.63 KB, patch)
2011-12-25 12:01 PST, Andreas Kling 		darin: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2011-12-25 12:01:42 PST
Created attachment 120512 [details] Proposed patch
WebKit Review Bot
Comment 2 2011-12-25 12:54:05 PST
Comment on attachment 120512 [details] Proposed patch Attachment 120512 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11027710 New failing tests: http/tests/inspector/resource-tree/resource-tree-document-url.html
Andreas Kling
Comment 3 2011-12-25 13:21:20 PST
Committed r103672: <http://trac.webkit.org/changeset/103672>
Note You need to log in before you can comment on or make changes to this bug.