Bug 75151

Summary: Add attributes field to JSArray's SparseMap
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: JavaScriptCoreAssignee: Gavin Barraclough <barraclough>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
The patch sam: review+

Gavin Barraclough
Reported 2011-12-22 16:29:11 PST
This will be necessary to be able to support non- writable/configurable/enumerable properties, and helpful for getters/setters.
Attachments
The patch (18.73 KB, patch)
2011-12-22 16:45 PST, Gavin Barraclough 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2011-12-22 16:45:29 PST
Created attachment 120409 [details] The patch
WebKit Review Bot
Comment 2 2011-12-22 16:46:51 PST
Attachment 120409 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/runtime/JSArray.cpp:451: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Source/JavaScriptCore/runtime/JSArray.cpp:452: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Source/JavaScriptCore/runtime/JSArray.h:30: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/JavaScriptCore/runtime/JSArray.h:33: Missing space inside { }. [whitespace/braces] [5] Total errors found: 4 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Gavin Barraclough
Comment 3 2011-12-22 17:44:50 PST
Fixed in r 103598/103599
Sam Weinig
Comment 4 2011-12-23 14:51:37 PST
Comment on attachment 120409 [details] The patch I reviewed this.
Note You need to log in before you can comment on or make changes to this bug.