Bug 75115 – Move some member variables out of ScrollElasticityController

• Component: New Bugs
• Status: RESOLVED FIXED

[Anders Carlsson]

Move some member variables out of ScrollElasticityController

[Anders Carlsson]

Created attachment 120366 [details]
Patch

[Adam Roben (:aroben)]

Comment on attachment 120366 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=120366&action=review

> Source/WebCore/platform/mac/ScrollAnimatorMac.mm:996
>              // in the opposite direction of the pin location, then we switch the
>              // boolean, and rubber band. That is, if we were pinned to the left,
>              // and we ended up scrolling to the right, we rubber band.

These comments make it sound like the members are in fact related to rubberbanding. What gives?

[Anders Carlsson]

(In reply to comment #2)
> (From update of attachment 120366 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=120366&action=review
> 
> > Source/WebCore/platform/mac/ScrollAnimatorMac.mm:996
> >              // in the opposite direction of the pin location, then we switch the
> >              // boolean, and rubber band. That is, if we were pinned to the left,
> >              // and we ended up scrolling to the right, we rubber band.
> 
> These comments make it sound like the members are in fact related to rubberbanding. What gives?

The comments are about when we should forward the event to the scroll elasticity controller, which is in charge of rubberbanding.

[Anders Carlsson]

Committed r103571: <http://trac.webkit.org/changeset/103571>