Bug 75114

Summary: Refactored String.prototype.replace
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: New BugsAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch darin: review+

Geoffrey Garen
Reported 2011-12-22 12:46:53 PST
Refactored String.prototype.replace
Attachments
Patch (24.54 KB, patch)
2011-12-22 13:00 PST, Geoffrey Garen 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2011-12-22 13:00:44 PST
Created attachment 120368 [details] Patch
Darin Adler
Comment 2 2011-12-22 14:48:33 PST
Comment on attachment 120368 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=120368&action=review > Source/JavaScriptCore/ChangeLog:15 > + * runtime/JSString.h: Removed the single-character case because it's no > + different from the normal case. (If we do come up with a single-character > + optimization in future, it probably doesn't belong in JSString, anyway.) What do you mean by no different from the normal case? Isn’t the find for a single character a different, faster function?
Geoffrey Garen
Comment 3 2011-12-23 07:32:23 PST
> What do you mean by no different from the normal case? Isn’t the find for a single character a different, faster function? Find for a single character is faster, but the general find knows to delegate to the single-character find if possible. So, we were just duplicating logic in the general find. I'll make the ChangeLog clearer on this point.
Geoffrey Garen
Comment 4 2011-12-23 07:39:01 PST
Committed r103626: <http://trac.webkit.org/changeset/103626>
Note You need to log in before you can comment on or make changes to this bug.