Bug 75097

Summary:

Need a function to expose m_visuallyNoEmptyCharacterCount in FrameView.

Product:

WebKit

Reporter:

Yongjun Zhang <yongjun_zhang>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

NEW

Severity:

Normal

CC:

yongjun_zhang

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Add function visuallyNonEmptyCharactersCount to return the number of visually non-empty characters from FrameView.	eric: review-

Yongjun Zhang

Reported 2011-12-22 10:42:54 PST

We need to have a function to expose m_visuallyNoEmptyCharacterCount in FrameView. That information would be useful to check how many RenderText characters are available in a page, for example.

Attachments
Add function visuallyNonEmptyCharactersCount to return the number of visually non-empty characters from FrameView. (2.23 KB, patch) 2011-12-22 11:44 PST, Yongjun Zhang	eric: review-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Yongjun Zhang

Comment 1 2011-12-22 11:44:44 PST

Created attachment 120355 [details] Add function visuallyNonEmptyCharactersCount to return the number of visually non-empty characters from FrameView.

Sam Weinig

Comment 2 2011-12-23 14:54:32 PST

Comment on attachment 120355 [details] Add function visuallyNonEmptyCharactersCount to return the number of visually non-empty characters from FrameView. View in context: https://bugs.webkit.org/attachment.cgi?id=120355&action=review > Source/WebCore/ChangeLog:3 > + Need a function to expose m_visuallyNoEmptyCharacterCount in FrameView. I think you mean m_visuallyNonEmptyCharacterCount. > Source/WebCore/ChangeLog:16 > + the page is already visually no empty. The value is reset at FrameView::reset(). Typo. no -> non. > Source/WebCore/page/FrameView.h:-507 > + m_visuallyNonEmptyCharacterCount += count; > if (m_isVisuallyNonEmpty) > return; > - m_visuallyNonEmptyCharacterCount += count; If we are incrementing this count even after becoming visually non-empty, I am not sure the variable name makes sense any more.

Yongjun Zhang

Comment 3 2012-01-03 09:38:49 PST

(In reply to comment #2) > (From update of attachment 120355 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=120355&action=review > > > Source/WebCore/ChangeLog:3 > > + Need a function to expose m_visuallyNoEmptyCharacterCount in FrameView. > > I think you mean m_visuallyNonEmptyCharacterCount. > > > Source/WebCore/ChangeLog:16 > > + the page is already visually no empty. The value is reset at FrameView::reset(). > > Typo. no -> non. > > > Source/WebCore/page/FrameView.h:-507 > > + m_visuallyNonEmptyCharacterCount += count; > > if (m_isVisuallyNonEmpty) > > return; > > - m_visuallyNonEmptyCharacterCount += count; > > If we are incrementing this count even after becoming visually non-empty, I am not sure the variable name makes sense any more. Yeah, these characters are always visually non-empty no matter when the page becomes visually non-empty or not. How about change the variable name to be m_renderedCharacterCount?

Yongjun Zhang

Comment 4 2012-01-03 09:39:02 PST

<rdar://problem/9209360>

Eric Seidel (no email)

Comment 5 2012-04-19 15:02:24 PDT

Comment on attachment 120355 [details] Add function visuallyNonEmptyCharactersCount to return the number of visually non-empty characters from FrameView. It looks like Sam was saying "please upload a new patch". :)

Note You need to log in before you can comment on or make changes to this bug.