Summary: | REGRESSION(r102987): Fix the filename prefix of the generated empty .h and .cpp files for [Supplemental] IDLs | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kentaro Hara <haraken> | ||||||||
Component: | WebCore Misc. | Assignee: | Kentaro Hara <haraken> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | abarth, japhet, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Kentaro Hara
2011-12-22 06:05:39 PST
Created attachment 120314 [details]
Patch
Comment on attachment 120314 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=120314&action=review > Source/WebCore/bindings/scripts/generate-bindings.pl:258 > + my $prefix = ""; > + if ($generator eq "JS") { > + $prefix = "JS"; > + } elsif ($generator eq "V8") { > + $prefix = "V8"; > + } elsif ($generator eq "ObjC") { > + $prefix = "DOM"; > + } elsif ($generator eq "GObject") { > + $prefix = "WebKitDOM"; > + } elsif ($generator eq "CPP") { > + $prefix = "WebDOM"; > + } else { > + die "Unknown generator: $generator\n"; > + } Yuck! Can we ask the generator what it's prefix should be rather than hardcoding a list of all the generator subclasses? Created attachment 120499 [details]
Patch
Created attachment 120500 [details]
Patch
(In reply to comment #2) > (From update of attachment 120314 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=120314&action=review > > Yuck! Can we ask the generator what it's prefix should be rather than hardcoding a list of all the generator subclasses? Done. Comment on attachment 120500 [details] Patch Clearing flags on attachment: 120500 Committed r103678: <http://trac.webkit.org/changeset/103678> All reviewed patches have been landed. Closing bug. |