Bug 75079

Summary: media/video-scales-in-media-document.html is Chromium specific
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: atwilson, dalecurtis, eric.carlson, morrita, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 75370    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Philippe Normand
Reported 2011-12-22 04:30:05 PST
Test introduced in r103489 fails on GTK because the patch only updates the Chromium media controls CSS...
Attachments
Patch (2.93 KB, patch)
2011-12-22 10:16 PST, Dale Curtis 		no flags
DetailsFormatted DiffDiff
Patch (2.42 KB, patch)
2011-12-22 15:26 PST, Dale Curtis 		no flags
DetailsFormatted DiffDiff
Patch (5.56 KB, patch)
2011-12-28 14:26 PST, Dale Curtis 		no flags
DetailsFormatted DiffDiff
Patch (5.56 KB, patch)
2011-12-29 18:13 PST, Dale Curtis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Dale Curtis
Comment 1 2011-12-22 10:16:12 PST
Created attachment 120337 [details] Patch
Dale Curtis
Comment 2 2011-12-22 10:17:24 PST
Sorry, patch sat in the CQ forever and I had to go before it landed. I've attached the proper Skipped files.
Philippe Normand
Comment 3 2011-12-22 11:53:54 PST
I skipped the test in GTK few hours ago.
Dale Curtis
Comment 4 2011-12-22 15:26:51 PST
Created attachment 120392 [details] Patch
Dale Curtis
Comment 5 2011-12-28 14:26:35 PST
Created attachment 120699 [details] Patch
Dale Curtis
Comment 6 2011-12-28 14:33:46 PST
New patch moves the test into platform/chromium/media and removes the Skipped entry for GTK.
WebKit Review Bot
Comment 7 2011-12-29 10:21:34 PST
Comment on attachment 120699 [details] Patch Clearing flags on attachment: 120699 Committed r103808: <http://trac.webkit.org/changeset/103808>
WebKit Review Bot
Comment 8 2011-12-29 10:21:39 PST
All reviewed patches have been landed. Closing bug.
Andrew Wilson
Comment 9 2011-12-29 14:13:25 PST
This patch broke this test on the chrome canary bots. I notice that the test relies on media-file.js and media-test.js, which don't exist in the new directory this was moved to?
Dale Curtis
Comment 10 2011-12-29 18:13:28 PST
Created attachment 120774 [details] Patch
Dale Curtis
Comment 11 2011-12-29 18:15:22 PST
Sorry, troubles working remotely. New patch up with fixed paths.
Andrew Wilson
Comment 12 2011-12-29 18:17:38 PST
It seems like the last patch could never have worked - should we run this through the chromium layout trybots before committing this time, if you're not able to test it remotely?
Dale Curtis
Comment 13 2011-12-29 18:23:17 PST
Not necessary, NX finally acquiesced and I was able to run the test.
WebKit Review Bot
Comment 14 2011-12-30 12:53:44 PST
Comment on attachment 120774 [details] Patch Clearing flags on attachment: 120774 Committed r103850: <http://trac.webkit.org/changeset/103850>
WebKit Review Bot
Comment 15 2011-12-30 12:53:50 PST
All reviewed patches have been landed. Closing bug.
Tony Chang
Comment 16 2012-01-06 16:38:45 PST
*** Bug 75235 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.