Bug 7503

Summary: Make kxmlcore/Assertions.cpp portable
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: WebKit Misc.Assignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P4    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
make assertions.cpp portable mjs: review+

Eric Seidel (no email)
Reported 2006-02-27 19:41:27 PST
Make kxmlcore/Assertions.cpp portable. This file had a bunch of Obj-c goop in it. I removed it. Pushed the mac specific logic up into WebCore. I tested this patch by setting my WebCoreLogLevel: defaults write com.apple.Safari WebCoreLogLevel 0xFFFFF then launching safari, and watching logs spew to the console. I know next-to-nothing about the logging mechanisms, but it seemed to be working.
Attachments
make assertions.cpp portable (22.66 KB, patch)
2006-02-27 19:42 PST, Eric Seidel (no email) 		mjs: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2006-02-27 19:42:19 PST
Created attachment 6765 [details] make assertions.cpp portable
Note You need to log in before you can comment on or make changes to this bug.